Repository navigation
embedding: centralize capabilities and complete OpenAI compatibility - #32481
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
github-actions
Bot
added
the
documentation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
mickqian
marked this pull request as ready for review
July 27, 2026 05:52
mickqian
requested review from
JustinTong0323,
sogalin,
wisclmy0611 and
zijiexia
as code owners
July 27, 2026 05:52
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mickqian
added
run-ci
mickqian
requested review from
CatherineSue,
ispobock,
merrymercy and
slin1237
as code owners
July 27, 2026 07:21
mickqian
force-pushed
the
codex/embedding-capability-foundation
branch
from
July 29, 2026 01:23
7d424dc to
3289535
Compare
2 tasks done
saturn-acc
pushed a commit
to saturn-acc/sglang
that referenced
this pull request
Aug 16, 2026
Atituiset
pushed a commit
to Atituiset/sglang
that referenced
this pull request
Sep 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmbeddingModelSpec, with automatic embedding-mode activation for native pooling-only encoder architectures while decoder embedding checkpoints retain explicit--is-embeddingintentencoding_format="base64"responses (little-endian FP32) and reject unsupported formatsvllm-embeddingtosglang.bench_serving, including engine-specific post-warmup cache reset, so SGLang BCG and vLLM use identical workloads and reportingsglang serve, state model-specific default knobs accurately, and document the fair comparison procedureValidation
PYTHONPATH=python python test/registered/unit/configs/test_embedding_model_spec.pypre-commit run --fileson all changed Python and documentation filesBenchmark follow-up
The paired H200 run is ready through
sglang-embeddingandvllm-embedding, but the registered H200 host is currently unreachable from this workstation (DNS/SSH). No unverified performance claim is made in this PR.CI States
Latest PR Test (Base): ✅ Run #30413917389
Latest PR Test (Extra): ❌ Run #30413917249