Observability enhancement for HiCache - #32388
Merged
Merged
Conversation
xiezhq-hermann
requested review from
Ying1123,
alphabetc1,
fzyzcjy,
hanming-lu,
hnyls2002,
hzh0425,
ispobock,
merrymercy,
sufeng-buaa and
yizhang2077
as code owners
July 25, 2026 08:20
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
xiezhq-hermann
requested review from
Alisehen,
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
OrangeRedeng,
Qiaolin-Yu,
b8zhong,
ch-wan,
hebiao064,
iforgetmyname,
jybsuper,
kpham-sgl,
lifuhuang,
ping1jing2 and
yushengsu-thu
as code owners
July 27, 2026 10:10
github-actions
Bot
added
documentation
xiezhq-hermann
force-pushed
the
hicache-l2-telemetry
branch
from
July 27, 2026 10:11
fc7706b to
580fa5e
Compare
xiezhq-hermann
added
run-ci
bypass-fastfail
and removed
documentation
21 tasks
Add metrics for the HiCache L2 (host) tier covering both HiRadixCache and UnifiedRadixCache: - Per-pool token counters and byte counters for D->H backup and H->D load-back, with sizes recorded for bandwidth calculation - Duration histograms for backup and load-back operations - Dropped-token counter for KV subtrees discarded without backup under host memory pressure
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduce several new metrics for HiCache observability including: separated cache hit counter from tiers, backuped token, load back token and dropped token (for write-back policy) counter, more accurate timing and memory footprint counter for live bandwidth computation.
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #30943224192
Latest PR Test (Extra): ✅ Run #30965794215