[Spec][DSV4] perf: Remove redundant draft metadata copies - #32319
Draft
mattteochen wants to merge 35 commits into
Draft
mattteochen wants to merge 35 commits into
mattteochen wants to merge 35 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
21 tasks
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up to #32194. After skipping unused DSV4 draft compression metadata, draft CUDA-graph replay still rebuilt and copied raw decode metadata on every step even though the captured request and sequence-length tensors already alias EAGLE's graph input buffers. This leaves five redundant eager DtoD copies before each draft graph launch.
Modifications
Accuracy
Speeup and profiling
main:

PR:

CI States
Latest PR Test (Base): ❌ Run #30095434236
Latest PR Test (Extra): ❌ Run #30095434013