[Fix] Resolve MiniMax-M3 top-level oneOf parameter schemas - #32299
Closed
adolphinvx wants to merge 1 commit into
Closed
adolphinvx wants to merge 1 commit into
adolphinvx wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Author
|
@JustinTong0323 This PR is ready for review. The current red checks are from |
5 tasks done
Author
|
Superseded by #36626, which generalizes this fix to root-level anyOf/oneOf/allOf and was merged into main on Aug 28, 2026. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #32286.
The MiniMax-M3 tool-call parser only looked for parameter schemas in direct
properties. When a tool used a top-leveloneOf, the parser could not findthe selected property's schema, so numbers were emitted as strings and arrays
leaked raw MiniMax parser tags.
Modifications
oneOfbranches.number-array branches from the reported failure.
Accuracy Tests
Not applicable. This changes deterministic tool-call argument parsing and does
not modify model inference or generated token output. The parser output is
covered by the regression unit test below.
Speed Tests and Profiling
Not applicable. The change adds a bounded schema lookup when a direct property
is not found and does not affect model execution.
Validation
python3 -m py_compileon the changed source and test.git diff --check.Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci.CI States
Latest PR Test (Base): ❌ Run #30080151515
Latest PR Test (Extra): ❌ Run #30080151468