Repository navigation
Conversation
hari-harmonic
requested review from
BBuf,
ByronHsu,
Edwardf0t1,
Fridge003,
HaiShaw,
ShangmingCai,
Ying1123,
ch-wan,
hnyls2002,
ispobock,
merrymercy,
sogalin and
xiezhq-hermann
as code owners
July 22, 2026 20:26
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
(cherry picked from commit a909077)
hari-harmonic
force-pushed
the
hari/keep-sampling-mask-sglang-miles
branch
from
July 22, 2026 20:36
9a72f42 to
ef14799
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #27408 onto
sglang-miles.Original merged PR: #27408
Cherry-picked commit: a909077
Notes:
sglang-milesunconditionalsend_kv_chunk.sglang-miles'sget_global_server_argsimport and adding theTOP_K_ALLimport required by the sampling-mask validation.Validation:
python3 -m compileall -qon the touched prefill/scheduler files after the conflict-resolution adjustment.python3 -m compileall -qover all touched runtime and test files passed.CI States
Latest PR Test (Base): ❌ Run #29955836553
Latest PR Test (Extra): ❌ Run #29955836352