Write-back policy fix for unified tree - #31845
Merged
Merged
Conversation
xiezhq-hermann
requested review from
Ying1123,
alphabetc1,
hanming-lu,
hnyls2002,
hzh0425,
ispobock,
merrymercy and
yizhang2077
as code owners
July 20, 2026 23:53
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
xiezhq-hermann
added
hicache
hzh0425
approved these changes
Jul 21, 2026
Collaborator
|
/rerun-group /radix_cache/unified_radix_tree/ |
Contributor
|
Results for 🚀 🚀 🚀 |
Jialin
added a commit
to Jialin/sglang
that referenced
this pull request
Jul 24, 2026
…l-project#31845) Trunk's write-back fix lands the host-lock pin (already carried by the split) plus its companion: when a write-back D-leaf's D->H backup fails under host memory pressure, drop the unbacked subtree (declining if any node is locked) so device eviction keeps making progress. Port the companion into the split structure: the subtree walk, layer release, and unbacked-leaf deletion live on UnifiedTreeCore (frees flow through the device/host free dicts); the controller invokes the fallback when the deferred write-back BackupKV comes back unwritten. Ports trunk's two write-back regression tests adapted to split node handles.
Jialin
added a commit
to Jialin/sglang
that referenced
this pull request
Jul 25, 2026
…l-project#31845) Trunk's write-back fix lands the host-lock pin (already carried by the split) plus its companion: when a write-back D-leaf's D->H backup fails under host memory pressure, drop the unbacked subtree (declining if any node is locked) so device eviction keeps making progress. Port the companion into the split structure: the subtree walk, layer release, and unbacked-leaf deletion live on UnifiedTreeCore (frees flow through the device/host free dicts); the controller invokes the fallback when the deferred write-back BackupKV comes back unwritten. Ports trunk's two write-back regression tests adapted to split node handles.
jinzhenfan
pushed a commit
to jinzhenfan/sglang
that referenced
this pull request
Jul 29, 2026
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
Atituiset
pushed a commit
to Atituiset/sglang
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We priorly introduced a few fixes for write-back policy with
HiRadixCache: #28614. This PR ports this toUnifiedRadixCacheas well as new unit tests.Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #29986203847
Latest PR Test (Extra): ✅ Run #29986203687