Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _make_prefill_runner method in test_multimodal_piecewise_cuda_graph.py by setting the capture_num_tokens attribute of the runner to [4, 16]. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
mickqian
marked this pull request as ready for review
July 18, 2026 10:21
Collaborator
Author
|
/tag-and-rerun-ci |
Zhylkaaa
pushed a commit
to Zhylkaaa/sglang
that referenced
this pull request
Jul 29, 2026
jinzhenfan
pushed a commit
to jinzhenfan/sglang
that referenced
this pull request
Jul 29, 2026
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize the lightweight
PrefillCudaGraphRunnertest fixtures with the state now read bycan_run_graph():capture_num_tokensin the multimodal piecewise CUDA graph fixture;prefill_backend_nameandhas_mha_companion_layersin the prefill-padding fixture.Root cause
#31391 and #31487 were developed from the same older
mainrevision and each added runner state plus a lightweight fixture built with__new__():Each PR's CPU tests passed in isolation because its fixture only needed the state present on that shared base. After both changes landed,
can_run_graph()read both sets of fields, exposing symmetric fixture drift: the multimodal fixture lackedcapture_num_tokens, while the padding fixture lacked the backend/MHA state.The fixtures now explicitly model
tc_piecewisebehavior and the[4, 16]capture buckets used by these tests.Impact
Test-only; runtime behavior is unchanged. This unblocks the affected
base-a-test-cpushard on currentmainand dependent PRs.Validation
pre-commit run --files test/registered/unit/configs/test_multimodal_piecewise_cuda_graph.py test/registered/unit/model_executor/runner/test_prefill_cuda_graph_padding.pygit diff --checknumpyis unavailable)CI States
Latest PR Test (Base): ⏳ Run #29641154932
Latest PR Test (Extra): ⏳ Run #29641154868