Skip to content

CI: synchronize prefill graph test fixtures - #31665

Merged
mickqian merged 2 commits into
sgl-project:mainfrom
mickqian:agent/initialize-prefill-cg-test-buckets
Jul 18, 2026
Merged

mickqian merged 2 commits into
sgl-project:mainfrom
mickqian:agent/initialize-prefill-cg-test-buckets

Conversation

@mickqian

@mickqian mickqian commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Synchronize the lightweight PrefillCudaGraphRunner test fixtures with the state now read by can_run_graph():

  • initialize capture_num_tokens in the multimodal piecewise CUDA graph fixture;
  • initialize prefill_backend_name and has_mha_companion_layers in the prefill-padding fixture.

Root cause

#31391 and #31487 were developed from the same older main revision and each added runner state plus a lightweight fixture built with __new__():

Each PR's CPU tests passed in isolation because its fixture only needed the state present on that shared base. After both changes landed, can_run_graph() read both sets of fields, exposing symmetric fixture drift: the multimodal fixture lacked capture_num_tokens, while the padding fixture lacked the backend/MHA state.

The fixtures now explicitly model tc_piecewise behavior and the [4, 16] capture buckets used by these tests.

Impact

Test-only; runtime behavior is unchanged. This unblocks the affected base-a-test-cpu shard on current main and dependent PRs.

Validation

  • pre-commit run --files test/registered/unit/configs/test_multimodal_piecewise_cuda_graph.py test/registered/unit/model_executor/runner/test_prefill_cuda_graph_padding.py
  • git diff --check
  • targeted runtime test deferred to CI because the local macOS environment lacks the SGLang Python dependencies (numpy is unavailable)

CI States

Latest PR Test (Base): ⏳ Run #29641154932
Latest PR Test (Extra): ⏳ Run #29641154868

@github-actions github-actions Bot added the Multi-modal multi-modal language model label Jul 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the _make_prefill_runner method in test_multimodal_piecewise_cuda_graph.py by setting the capture_num_tokens attribute of the runner to [4, 16]. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mickqian
mickqian marked this pull request as ready for review July 18, 2026 10:21
@mickqian

Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@mickqian mickqian changed the title test: initialize prefill graph capture buckets CI: initialize prefill graph capture buckets Jul 18, 2026
@mickqian mickqian changed the title CI: initialize prefill graph capture buckets CI: synchronize prefill graph test fixtures Jul 18, 2026
@mickqian
mickqian merged commit 573c075 into sgl-project:main Jul 18, 2026
82 of 91 checks passed
Zhylkaaa pushed a commit to Zhylkaaa/sglang that referenced this pull request Jul 29, 2026
jinzhenfan pushed a commit to jinzhenfan/sglang that referenced this pull request Jul 29, 2026
Chronostasys pushed a commit to MindLab-Research/sglang that referenced this pull request Aug 24, 2026
jakki-amd pushed a commit to jakki-amd/sglang that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Multi-modal multi-modal language model run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant