Skip to content

[Test] Cover tensors excluded from WeightChecker reset #31621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuchenwang3 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

[Test] Cover tensors excluded from WeightChecker reset #31621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/registered/unit/utils/test_weight_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,15 @@ def test_changes_normal_params_in_place(self):
self.assertEqual(self.model.w.data_ptr(), before_w_ptr)
self.assertFalse(torch.equal(self.model.w, before_w))

def test_preserves_tensors_excluded_from_weight_check(self):
"""Unchecked tensors may not be restored, so reset must preserve them."""
self.model.w._skip_weight_check = True
before_w = self.model.w.clone()

self.checker._reset_tensors()

torch.testing.assert_close(self.model.w, before_w)

def test_skips_cos_sin_cache(self):
before = self.model.rotary_emb_cos_sin_cache.clone()
self.checker._reset_tensors()
Expand Down
Loading