-
Notifications
You must be signed in to change notification settings - Fork 8.9k
metrics: allow extra labels on HTTP request/response Prometheus metrics #31530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ispobock
merged 4 commits into
sgl-project:main
from
sshleifer:sam/upstream-prometheus-extra-labels
Jul 18, 2026
+15
−7
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
603f918
metrics: allow extra labels on HTTP request/response Prometheus metrics
de04ae4
Merge branch 'main' into sam/upstream-prometheus-extra-labels
ispobock 1eb9719
fix lint
ispobock 901154c
Merge branch 'main' into sam/upstream-prometheus-extra-labels
ispobock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the normal HTTP-server launch path, the only in-repo call remains
add_prometheus_track_response_middleware(app)inpython/sglang/srt/entrypoints/http_server.py:2370, soServerArgs.extra_metric_labelsnever reaches this new parameter. Deployments using--extra-metric-labelswill still get those labels on scheduler/tokenizer metrics but not on these HTTP counters/gauges, which defeats the new filtering/joining use case this parameter is meant to support.Useful? React with 👍 / 👎.