ci: add MLX to coverage report backend display order - #31442
Merged
Merged
Conversation
The nightly CI Coverage Overview has failed since MLX was added to HWBackend (#30121): the report's sync guard asserts that BACKEND_DISPLAY_ORDER covers every enum member, exactly so a new backend can't be silently dropped from the tables. Add MLX after MUSA (most recently wired accelerator). Verified all three sections (summary / by-folder / by-suite) render locally; MLX shows its 12 registrations.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CI coverage report utility to include the 'MLX' backend in the display order configuration. There are no review comments, and I have no feedback to provide on these changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Collaborator
Author
Zhylkaaa
pushed a commit
to Zhylkaaa/sglang
that referenced
this pull request
Jul 29, 2026
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The nightly CI Coverage Overview fails since #30121 added
MLXtoHWBackend: the report's sync guard requiresBACKEND_DISPLAY_ORDERto cover every enum member so new backends can't be silently dropped from the tables.Modifications
Add
MLXtoBACKEND_DISPLAY_ORDER. Verified locally: all three sections (summary/by-folder/by-suite) render, MLX shows its 12 registrations.CI States
Latest PR Test (Base): ❌ Run #29483049639
Latest PR Test (Extra): ❌ Run #29483048550