[Kernel] Hotfix: update sgl-kernel imports of relocated fp8_kernel (RFC #29630 #30784) - #31089
Merged
Merged
Conversation
RFC sgl-project#29630 Phase 2.5 PR sgl-project#30784 relocated fp8_kernel from sglang.srt.layers.quantization.fp8_kernel to sglang.kernels.ops.quantization.fp8_kernel (no shim), but the import rewrite only covered python/sglang, test/ and benchmark/ — it missed the sgl-kernel/ subtree, so three sgl-kernel test/benchmark modules still imported the old path and now fail collection (ModuleNotFoundError), breaking the 'sgl-kernel unit tests on B200' CI job on main. Rewrite the three stale imports to the new path; all imported symbols (per_token_group_quant_8bit, sglang_per_token_group_quant_8bit, w8a8_block_fp8_matmul_triton, create_per_token_group_quant_fp8_output_scale) exist there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
BBuf
requested review from
FlamingoPg,
HaiShaw,
ispobock,
merrymercy and
yizhang2077
as code owners
July 14, 2026 00:34
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
sgl-project#29630 sgl-project#30784) (sgl-project#31089) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
sgl-project#29630 sgl-project#30784) (sgl-project#31089) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RFC #29630 Phase 2.5 PR #30784 relocated
fp8_kernelfromsglang.srt.layers.quantization.fp8_kernel→sglang.kernels.ops.quantization.fp8_kernel(move + rewrite all imports, no compatibility shim).
The import rewrite covered
python/sglang/,test/andbenchmark/, but missed thesgl-kernel/subtree. Threesgl-kerneltest/benchmark modules still import the oldpath, so after #30784 merged they fail at collection with:
This breaks the
Run sgl-kernel unit tests on B200job onmainfor every PR (e.g. itsurfaced on an unrelated PR's CI), not just the migration PRs.
Fix
Rewrite the three stale imports to the new path:
sgl-kernel/tests/test_per_token_group_quant_8bit.pysgl-kernel/benchmark/bench_per_token_group_quant_8bit.pysgl-kernel/benchmark/bench_fp8_blockwise_gemm.pysglang.srt.layers.quantization.fp8_kernel→sglang.kernels.ops.quantization.fp8_kernelAll imported symbols —
per_token_group_quant_8bit,sglang_per_token_group_quant_8bit,w8a8_block_fp8_matmul_triton,create_per_token_group_quant_fp8_output_scale— exist atthe new path (the relocation was byte-identical). Pure import-path change, no behavior change.
Verified: no
srt.layers.quantization.fp8_kernelreferences remain anywhere insgl-kernel/,and a repo-wide sweep confirms these three were the only stale old-path Python imports left
(the other relocated quant modules — int8_kernel / mxfp8 / awq / nvfp4 — have no old-path
consumers in the skipped dirs).
🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #29296300849
Latest PR Test (Extra): ❌ Run #29296408618