Repository navigation
[Cherry-pick to release/v0.5.15] Stabilize GLM-5.2 MTP IndexShare across PD and CUDA graph replay (#30839) - #31083
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
…eplay Backport of #30839 to release/v0.5.15 (squashed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kpham-sgl
force-pushed
the
glm52-pd-v0.5.15post1
branch
from
July 14, 2026 00:20
5e80b91 to
27dd90d
Compare
Collaborator
Author
|
Internal nightly run #0e8ae04b has passed GSM8K. Accept length of PD Disagg also looks healthy > 5 |
kpham-sgl
marked this pull request as ready for review
July 14, 2026 00:43
kpham-sgl
requested review from
Fridge003,
Qiaolin-Yu,
Ying1123,
hnyls2002,
ispobock and
merrymercy
as code owners
July 14, 2026 00:43
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
kpham-sgl
requested review from
1am9trash,
ByronHsu,
HaiShaw,
ShangmingCai,
YAMY1234,
ch-wan,
fzyzcjy,
hebiao064,
hubertlu-tw,
kkHuang-amd,
rainj-me,
sogalin and
xiezhq-hermann
as code owners
July 14, 2026 00:43
Collaborator
|
Validated with GLM-5.2-NVFP4 (agentic multi-turn workload, ISL ≈ 80k, EAGLE 5/1/6) on 4×GB300 and 8×B300: no perf regression (within run-to-run noise vs release without this change), acceptance length unchanged, and no degenerate output across all generated turns. 4×GB300
8×B300
* depressed by one-time JIT compile on the cold first step; interactivity unaffected. |
3 of 5 tasks
4 of 6 tasks
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
…oss PD and CUDA graph replay (sgl-project#30839) (sgl-project#31083) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #30839 to
release/v0.5.15.Structured as two commits to stay conflict-free against the release branch:
Motivation
This PR makes GLM-5.2 MTP IndexShare reliable across PD disaggregation, context parallelism, overlap scheduling, batch splitting, and CUDA graph replay. It preserves the correct draft-extend DSA seed across draft steps, avoiding redundant indexer computation without reusing stale or misaligned indices. This improves proposal consistency, acceptance length stability, and inference performance.
This is a follow-up to #29787. The optimization remains gated to EAGLE with
speculative_eagle_topk == 1,index_share_for_mtp_iteration=true, and a validindex_topk.Modifications
LogitsProcessorOutput, including correct last-token extraction after CP gather/reordering.FutureMapto prevent stale overlap/PD state, and fall back to eager recomputation when no valid seed is available.🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #29295651002
Latest PR Test (Extra): ❌ Run #29295650791