Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
585989a
[AMD] [Docker] Add Python 3.12 + torch 2.11 + triton 3.6.0 flavor for…
chuyeh Jul 13, 2026
4f71984
Add env var to mitigate memory leak issue.
chuyeh Jul 20, 2026
7b04d01
ci(amd): support custom image testing for ROCm 7.2
chuyeh Jul 20, 2026
218ccf6
ci(amd): allow targeted ROCm 7.2 image builds
chuyeh Jul 21, 2026
adcb73e
ci(amd): pin CMake for ROCm MORI build
chuyeh Jul 21, 2026
f9e9076
ci(amd): install gRPC headers before MORI reinstall
chuyeh Jul 22, 2026
6239a51
Merge upstream main into ROCm 7.2 Docker PR
chuyeh Jul 22, 2026
539e274
[ROCm] Scope the 7.2.4 upgrade to dedicated gfx942/gfx950 stages
chuyeh Jul 28, 2026
35f0261
ci(amd): add ROCm 7.2.4 build and test workflows
chuyeh Jul 28, 2026
b2b4b8f
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Jul 29, 2026
7da5063
ci(amd): sync rocm724 PR test workflow with its rocm720 template
chuyeh Jul 29, 2026
2dff06e
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 3, 2026
6ef56f3
ci(amd): re-sync rocm724 stages and workflow with upstream
chuyeh Aug 3, 2026
3cbf1ae
ci(amd): hold the rocm724 AITER pin at the validated commit
chuyeh Aug 3, 2026
51d31bd
fix(amd): stabilize ROCm 7.2.4 CI images
chuyeh Aug 4, 2026
f205576
Merge upstream main into ROCm 7.2.4 image branch
chuyeh Aug 6, 2026
8211560
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 6, 2026
4d91a8c
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 7, 2026
055e9ac
fix(triton): pass USE_PDL explicitly for torch.compile launcher
chuyeh Aug 7, 2026
07102cd
Revert "fix(triton): pass USE_PDL explicitly for torch.compile launcher"
chuyeh Aug 7, 2026
9be67cf
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 7, 2026
eda06bb
fix(rocm): let ROCm 7.2.4 AITER manage Triton
bingxche Aug 7, 2026
f6533b1
fix(ci): use AITER Triton for ref overrides
bingxche Aug 7, 2026
cbe77f5
fix(rocm): use AITER-pinned Triton on ROCm 7.2
bingxche Aug 10, 2026
3860dba
fix(rocm): apply AITER stream patch to ROCm 7.2.0
chuyeh Aug 12, 2026
1d29788
Merge upstream/main into ROCm 7.2 image branch
chuyeh Aug 12, 2026
d6de7cc
ci(rocm): consolidate ROCm 7.2 workflows
chuyeh Aug 12, 2026
230aa9b
Merge remote ROCm image branch
chuyeh Aug 12, 2026
83c23f4
Merge upstream/main into ROCm 7.2 image branch
chuyeh Aug 12, 2026
515ffc7
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 12, 2026
2c6c73c
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 13, 2026
bb19703
ci(amd): drop the spaces from SGL_EVAL_SPEC
chuyeh Aug 13, 2026
d442332
fix(rocm): keep the AITER stream patch across CI rebuilds
chuyeh Aug 13, 2026
9b2bf56
ci(amd): add rocm724 to the release matrices instead of replacing roc…
chuyeh Aug 13, 2026
e86c249
ci(amd): keep rocm720 as the PR test default
chuyeh Aug 13, 2026
d18a490
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 14, 2026
59b0a16
[AMD] Fix torch's dangling triton-rocm requirement on ROCm 7.2.4
chuyeh Aug 14, 2026
67e4193
[AMD] Mark patch_torch_triton_requirement.py executable
chuyeh Aug 14, 2026
118780b
[AMD] Upgrade ROCm 7.2.0 to torch 2.11
chuyeh Aug 18, 2026
6c5ecf1
Revert "[AMD] Upgrade ROCm 7.2.0 to torch 2.11"
chuyeh Aug 18, 2026
f38fcc6
[AMD] Address review findings on the ROCm 7.2.4 image
chuyeh Aug 18, 2026
d72db29
[AMD] Drop the custom-image arch retarget, deferring to AMD_CI_IMAGE_…
chuyeh Aug 18, 2026
f6e6d17
[AMD] Clear the remaining review notes on the ROCm 7.2.4 image
chuyeh Aug 18, 2026
dc1b60f
Merge remote-tracking branch 'upstream/main' into feat/rocm7.2-torch2…
chuyeh Aug 18, 2026
feeb2c8
[AMD] Read AITER_COMMIT from the matching ROCm Dockerfile stage
chuyeh Aug 18, 2026
1d5aa0b
[AMD] Stamp GPU_ARCH on ROCm images for AITER pin lookup
chuyeh Aug 18, 2026
0eaf223
[AMD] Fail-fast release builds, share flavor detection, drop the left…
chuyeh Aug 19, 2026
e055a1e
[AMD] Install libdrm-amdgpu on ROCm 7.2.4 images
chuyeh Aug 19, 2026
5026c9e
[AMD] Keep rocm.Dockerfile self-contained and pin Triton 3.7
chuyeh Aug 19, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/pr-test-amd-extra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,24 @@ on:
- mi300
- mi325
rocm_version:
description: 'ROCm container variant (rocm720 = ROCm 7.2.0, the PR default; rocm700 = ROCm 7.0.0)'
description: 'ROCm container variant (ROCm 7.2.0 by default)'
required: false
type: choice
default: rocm720
options:
- rocm720
- rocm724
- rocm700
aiter_ref:
description: 'Override AITER commit (optional, leave empty to use Dockerfile default)'
required: false
type: string
default: ''
amd_ci_image:
description: 'Override AMD CI Docker image (optional, e.g. rocm/sgl-dev:tag)'
required: false
type: string
default: ''
continue_on_error:
description: 'Continue on error (do not fail the workflow on test failures)'
required: false
Expand All @@ -67,7 +73,7 @@ on:
type: string
default: mi300
rocm_version:
description: 'ROCm container variant (rocm720 = ROCm 7.2.0, the PR default; rocm700 = ROCm 7.0.0)'
description: 'ROCm container variant (ROCm 7.2.0 by default)'
required: false
type: string
default: rocm720
Expand All @@ -76,6 +82,11 @@ on:
required: false
type: string
default: ''
amd_ci_image:
description: 'Override AMD CI Docker image (optional, e.g. rocm/sgl-dev:tag)'
required: false
type: string
default: ''
continue_on_error:
description: 'Continue on error (do not fail the workflow on test failures)'
required: false
Expand All @@ -84,6 +95,7 @@ on:

env:
AITER_COMMIT_OVERRIDE: ${{ inputs.aiter_ref }}
AMD_CI_IMAGE: ${{ inputs.amd_ci_image }}
DOCKERHUB_AMD_USERNAME: ${{ secrets.DOCKERHUB_AMD_USERNAME }}
DOCKERHUB_AMD_TOKEN: ${{ secrets.DOCKERHUB_AMD_TOKEN }}

Expand Down Expand Up @@ -145,7 +157,7 @@ jobs:

- name: Start CI container
# `inputs` is empty on pull_request events, so fall back explicitly to
# the ROCm 7.2 PR default. Reusable callers can still request ROCm 7.0.
# the ROCm 7.2 PR default. Reusable callers can request another variant.
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version ${{ inputs.rocm_version || 'rocm720' }}
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
Expand Down
66 changes: 46 additions & 20 deletions .github/workflows/pr-test-amd-rocm720.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ on:
- "docker/rocm.Dockerfile"
workflow_dispatch:
inputs:
rocm_version:
description: 'ROCm image version'
required: false
type: choice
default: rocm720
options:
- rocm720
- rocm724
target_stage_select:
description: "Select a stage to run from dropdown (leave empty for auto-detect)"
required: false
Expand Down Expand Up @@ -57,6 +65,11 @@ on:
required: false
type: string
default: ''
amd_ci_image:
description: 'Override AMD CI Docker image (optional, e.g. rocm/sgl-dev:tag)'
required: false
type: string
default: ''
continue_on_error:
description: 'Continue on error (do not fail the workflow on test failures)'
required: false
Expand All @@ -77,6 +90,11 @@ on:
default: false
workflow_call:
inputs:
rocm_version:
description: 'ROCm image version'
required: false
type: string
default: rocm720
ref:
description: 'Git ref (branch, tag, or SHA) to test. If not provided, uses the default branch.'
required: false
Expand All @@ -97,6 +115,11 @@ on:
required: false
type: string
default: ''
amd_ci_image:
description: 'Override AMD CI Docker image (optional, e.g. rocm/sgl-dev:tag)'
required: false
type: string
default: ''
continue_on_error:
description: 'Continue on error (do not fail the workflow on test failures)'
required: false
Expand All @@ -116,6 +139,8 @@ permissions:

env:
AITER_COMMIT_OVERRIDE: ${{ inputs.aiter_ref }}
AMD_CI_IMAGE: ${{ inputs.amd_ci_image }}
ROCM_VERSION: ${{ inputs.rocm_version || 'rocm720' }}
DOCKERHUB_AMD_USERNAME: ${{ secrets.DOCKERHUB_AMD_USERNAME }}
DOCKERHUB_AMD_TOKEN: ${{ secrets.DOCKERHUB_AMD_TOKEN }}

Expand Down Expand Up @@ -225,8 +250,9 @@ jobs:
with:
ref: ${{ inputs.pr_head_sha || inputs.ref || '' }}
runner_arch: ${{ inputs.runner_arch || 'mi300' }}
rocm_version: rocm720
rocm_version: ${{ inputs.rocm_version || 'rocm720' }}
aiter_ref: ${{ inputs.aiter_ref }}
amd_ci_image: ${{ inputs.amd_ci_image }}
continue_on_error: true
secrets: inherit

Expand Down Expand Up @@ -255,7 +281,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -313,7 +339,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -354,7 +380,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -391,7 +417,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -428,7 +454,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -496,7 +522,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -532,7 +558,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -571,7 +597,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -612,7 +638,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -653,7 +679,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -702,7 +728,7 @@ jobs:
pattern: wheel-python3.10-cuda12.9

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -833,7 +859,7 @@ jobs:
pattern: wheel-python3.10-cuda12.9

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -963,7 +989,7 @@ jobs:
pattern: wheel-python3.10-cuda12.9

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -1040,7 +1066,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -1099,7 +1125,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -1145,7 +1171,7 @@ jobs:
run: bash scripts/ci/amd/ensure_vram_clear.sh rocm

- name: Start CI container
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down Expand Up @@ -1189,7 +1215,7 @@ jobs:
- name: Setup docker (ROCm 7.2)
run: |
touch github_summary.md
bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
ENABLE_CACHE_HOST: "1"
Expand Down Expand Up @@ -1243,7 +1269,7 @@ jobs:
- name: Setup docker (ROCm 7.2)
run: |
touch github_summary.md
bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version rocm720
bash scripts/ci/amd/amd_ci_start_container.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
ENABLE_CACHE_HOST: "1"
Expand Down Expand Up @@ -1336,7 +1362,7 @@ jobs:
echo "=== Host RDMA Check Complete ==="

- name: Start Special Container
run: bash scripts/ci/amd/amd_ci_start_container_disagg.sh --rocm-version rocm720
run: bash scripts/ci/amd/amd_ci_start_container_disagg.sh --rocm-version "$ROCM_VERSION"
env:
GITHUB_WORKSPACE: ${{ github.workspace }}

Expand Down
21 changes: 18 additions & 3 deletions .github/workflows/release-docker-amd-rocm720-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@ on:
options:
- 'all'
- publish
gpu_arch:
description: 'Select which ROCm 7.2 GPU arch to build'
required: false
type: choice
default: 'all'
options:
- 'all'
- gfx942-rocm724
- gfx950-rocm724
- gfx942-rocm720
- gfx950-rocm720
schedule:
- cron: '0 12 * * *'

Expand All @@ -29,7 +40,7 @@ jobs:
strategy:
fail-fast: false
matrix:
gpu_arch: ['gfx942-rocm720', 'gfx950-rocm720']
gpu_arch: ${{ fromJson((github.event_name == 'workflow_dispatch' && inputs.gpu_arch != 'all' && inputs.gpu_arch != '') && format('["{0}"]', inputs.gpu_arch) || '["gfx942-rocm720", "gfx950-rocm720", "gfx942-rocm724", "gfx950-rocm724"]') }}
build_type: ['all']
steps:
- name: Checkout repository
Expand Down Expand Up @@ -81,7 +92,11 @@ jobs:
echo "Version: ${version}"
echo "Pretend version: ${pretend_version}"

if [ "${{ matrix.gpu_arch }}" = "gfx942-rocm720" ]; then
if [ "${{ matrix.gpu_arch }}" = "gfx942-rocm724" ]; then
rocm_tag="rocm724-mi30x"
elif [ "${{ matrix.gpu_arch }}" = "gfx950-rocm724" ]; then
rocm_tag="rocm724-mi35x"
elif [ "${{ matrix.gpu_arch }}" = "gfx942-rocm720" ]; then
rocm_tag="rocm720-mi30x"
elif [ "${{ matrix.gpu_arch }}" = "gfx950-rocm720" ]; then
rocm_tag="rocm720-mi35x"
Expand Down Expand Up @@ -141,7 +156,7 @@ jobs:
strategy:
fail-fast: false
matrix:
gpu_arch: ['gfx942-rocm720', 'gfx950-rocm720']
gpu_arch: ${{ fromJson((github.event_name == 'workflow_dispatch' && inputs.gpu_arch != 'all' && inputs.gpu_arch != '') && format('["{0}"]', inputs.gpu_arch) || '["gfx942-rocm720", "gfx950-rocm720", "gfx942-rocm724", "gfx950-rocm724"]') }}
steps:
- name: Download image tag artifact
uses: actions/download-artifact@v4
Expand Down
Loading
Loading