Fix CuTe DSL DSA paged MQA export - #30627
Merged
Merged
Conversation
mmangkad
requested review from
BBuf,
DarkSharpness,
HydraQYH,
celve and
yuan-luo
as code owners
July 9, 2026 09:07
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the conditional import of CuteDSLPagedMQALogitsRunner and pick_dsl_expand to the top of the init.py file. The reviewer noted that because these variables are unconditionally listed in all, an AttributeError will occur on ROCm platforms where they are not imported. It is recommended to define them as None when is_hip() is True to prevent this issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
mmangkad
force-pushed
the
mmangkad/fix-cutedsl-dsa-export
branch
2 times, most recently
from
July 9, 2026 09:45
10c5e0e to
b4a0463
Compare
mmangkad
requested review from
1am9trash,
Fridge003,
HaiShaw,
YAMY1234,
hubertlu-tw,
kkHuang-amd and
rainj-me
as code owners
July 9, 2026 09:45
mmangkad
force-pushed
the
mmangkad/fix-cutedsl-dsa-export
branch
from
July 9, 2026 09:48
7185afb to
edd5785
Compare
mmangkad
force-pushed
the
mmangkad/fix-cutedsl-dsa-export
branch
2 times, most recently
from
July 10, 2026 08:22
b08d9df to
e20e1e5
Compare
mmangkad
force-pushed
the
mmangkad/fix-cutedsl-dsa-export
branch
from
July 10, 2026 08:27
e20e1e5 to
0d13af0
Compare
Fridge003
approved these changes
Jul 10, 2026
This was referenced Jul 10, 2026
Fridge003
pushed a commit
that referenced
this pull request
Jul 12, 2026
This was referenced Jul 13, 2026
5 tasks
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the CuTe DSL paged MQA export that got broken by the import reordering in #30374. Before this change, the export pointed at the module instead of the function. This puts the order back so callers get the function again.
I also made the CuTe DSL helper import CUDA-only. For NPU, ROCm, and other backends, we leave a
Noneplaceholder instead of trying to load CUDA-only code.CI States
Latest PR Test (Base): 🚫 Run #29079820810
Latest PR Test (Extra): ✅ Run #29147456875