Move breakable CUDA graph back into model_executor/runner_backend_utils - #30586
Merged
Merged
Conversation
Oasis-Git
requested review from
BBuf,
Fridge003,
Ying1123,
hnyls2002,
ispobock,
merrymercy,
mickqian,
ping1jing2,
yhyang201 and
yingluosanqian
as code owners
July 9, 2026 02:33
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
The srt breakable CUDA graph core returns byte-identical to its state before sgl-project#27436 (back at srt/model_executor/runner_backend_utils/breakable_cuda_graph, dedup support and capture-failure logging restored, top-level srt/breakable_cuda_graph package removed). The diffusion BCG feature is kept and adapted to the pre-PR core: - replay-token machinery moves to multimodal_gen/runtime/breakable_cuda_graph/replay_token.py; the mm runner stamps a token around each graph.replay() - tuple-returning attention forwards (UlyssesAttention, used by Z-Image) are boxed into an attribute object for the break point, since the pre-PR _copy_output copies objects-with-tensor-attrs in place but ignores tuples - layer.py imports repoint accordingly Verified: core files byte-identical to ead1e49; all consumers import; GPU capture/replay of a boxed tuple break point produces fresh outputs on every replay; 16/16 BCG unit tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Oasis-Git
requested review from
AgainstEntropy,
HaiShaw and
yichiche
as code owners
July 9, 2026 02:50
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BBuf
approved these changes
Jul 9, 2026
This was referenced Jul 11, 2026
This was referenced Jul 19, 2026
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
…ls (sgl-project#30586) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the package relocation from #27436, which hoisted the BCG core out to sglang.srt.breakable_cuda_graph. The full implementation now lives back at
sglang.srt.model_executor.runner_backend_utils.breakable_cuda_graph and the top-level package is removed; all importers are repointed.
Motivation
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ⏳ Run #28991132395
Latest PR Test (Extra): ❌ Run #28991132207