Skip to content

[Cherry pick to release/v0.5.15] Fix NVFP4 online quantization - #30397

Merged
Fridge003 merged 1 commit into
mainfrom
brayden/fix-ci-1
Jul 7, 2026
Merged

[Cherry pick to release/v0.5.15] Fix NVFP4 online quantization#30397
Fridge003 merged 1 commit into
mainfrom
brayden/fix-ci-1

Conversation

@b8zhong

@b8zhong b8zhong commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

test/registered/backends/test_flashinfer_trtllm_gen_moe_backend.py
AttributeError: 'NvFp4OnlineConfig' object has no attribute 'dequant_fp4_to_fp8'

It's broken by #27867


CI States

Latest PR Test (Base): ❌ Run #28869009529
Latest PR Test (Extra): 🚫 Run #28869008915

@b8zhong b8zhong changed the title [Cherry pick to release/v0.5.15] [Cherry pick to release/v0.5.15] Fix NVFP4 online quantization Jul 7, 2026
@github-actions github-actions Bot added the blackwell SM100/SM120 label Jul 7, 2026
@b8zhong

b8zhong commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

/rerun-test test/registered/backends/test_flashinfer_trtllm_gen_moe_backend.py

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/backends/test_flashinfer_trtllm_gen_moe_backend.py:

🚀 4-gpu-b200 (1 test): ✅ View workflow run

cd test/ && python3 registered/backends/test_flashinfer_trtllm_gen_moe_backend.py

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the dequant_fp4_to_fp8 attribute, initialized to False, to the quantization configuration in nvfp4_online.py. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Fridge003
Fridge003 merged commit e2ea7aa into main Jul 7, 2026
115 of 139 checks passed
@Fridge003
Fridge003 deleted the brayden/fix-ci-1 branch July 7, 2026 20:20
Fridge003 pushed a commit that referenced this pull request Jul 7, 2026
… NVFP4 online quantization (#30397) (#30424)

Co-authored-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Co-authored-by: Brayden Zhong <brayden@radixark.ai>
mattteochen pushed a commit to mattteochen/sglang that referenced this pull request Jul 8, 2026
yangspirit pushed a commit to yangspirit/sglang that referenced this pull request Jul 8, 2026
Chronostasys pushed a commit to MindLab-Research/sglang that referenced this pull request Aug 24, 2026
… NVFP4 online quantization (sgl-project#30397) (sgl-project#30424)

Co-authored-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Co-authored-by: Brayden Zhong <brayden@radixark.ai>
Chronostasys pushed a commit to MindLab-Research/sglang that referenced this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants