Support MiMo V2.5 with zigzag context parallelism - #29972
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
2b0e4f8 to
2b2b195
Compare
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
2b2b195 to
609a7ff
Compare
|
Please consider this comment in this PR. We need to handle this padding somewhere in cp_v2 |
609a7ff to
887fd97
Compare
78bef16 to
32b3f41
Compare
|
@Fridge003 ready for review at I rebased and force-pushed on current Fresh exact-tree validation on
The PR title/body now reflect the zigzag implementation and exact validation evidence. |
|
/rerun-test test/registered/cp/test_gqa_prefill_cp.py test/registered/cp/test_cp_strategy_unit.py test/registered/cp/test_deepseek_v3_cp_single_node.py |
|
Results for 🚀 🚀 🚀 |
|
Please skip the padding at https://github.com/sgl-project/sglang/blob/main/python/sglang/srt/model_executor/forward_batch_info.py#L1184 when cp_v2 is enabled. We wish that CP_V2 can handle the padding on its side. Please open a new file |
|
Do we need to consider this place if all the padding logics are managed under cp_v2? If not, we can skip padding max_seq_len_k for cp_v2 sglang/python/sglang/srt/layers/attention/flashattention_backend.py Lines 632 to 648 in c1067f8 |
|
Add a unit test for checking the correctness of padding logics |
e4701a3 to
04a86ac
Compare
|
Remove the async all gather operations as before |
04a86ac to
6ff6ee3
Compare
|
/rerun-test test/registered/cp/test_gqa_prefill_cp.py test/registered/cp/test_cp_strategy_unit.py test/registered/cp/test_deepseek_v3_cp_single_node.py test/registered/cp/test_mimo_cp.py |
|
Results for 🚀 🚀 🚀 🚀 |
6ff6ee3 to
f34ee0f
Compare
|
/rerun-test test/registered/cp/test_gqa_prefill_cp.py test/registered/cp/test_cp_strategy_unit.py test/registered/cp/test_deepseek_v3_cp_single_node.py test/registered/cp/test_mimo_cp.py |
|
Results for 🚀 🚀 🚀 🚀 |
Summary
Adds text-only MiMo V2.5 support to CP-v2 with FA4 and zigzag prefill context parallelism.
Key changes:
layers/cp/padding.py.--language-onlyworkers when the model also advertises image capability.This PR does not add multimodal, MTP, interleave, fused-QKV-interleaving, DP-attention, communicator, or decode-CP behavior.
Validation
Validated exact commit
04a86ac7be72d4da1dcb0096ac657293754274b1, based directly onmainatb8ec544946f1c5b6e17a919a691b05c5b3e7af84:test/registered/cp/test_cp_strategy_unit.pyon GB300: 11 passed, 14 subtests passed in 11.44 s.baizhou-dev+baizhou-dev-2, with 4 GB300 GPUs per node,--tp 8,--attn-cp-size 2, FA4, zigzag prefill CP,--language-only, and dense MoE TP1.The cross-node validation used
NCCL_MNNVL_ENABLE=0,NCCL_LAUNCH_ORDER_IMPLICIT=1, and--disable-cuda-graph. These are validation-only settings for the allocated two-node devboxes; this PR adds no CUDA-graph workaround.CI States
Latest PR Test (Base): ❌ Run #29681234251
Latest PR Test (Extra): ❌ Run #29681234158