-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Fix] Address remaining issues of supporting MiniCPMV #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d4a7a2d to
d32da67
Compare
|
Great work! Once ready, please ask us to review. |
|
also remove these vllm dependency sglang/python/sglang/srt/layers/attention/vision.py Lines 8 to 9 in 2584f6d
|
6f78efe to
797ac44
Compare
|
@mickqian mick, great work. So we are ended and just need to past the review? Thanks! |
b09c28b to
bee8340
Compare
|
@mickqian there are still some failed cases, but it seems they are not related to your pr? |
Yeah. CI is wrong possibly due to kernel or largely refactor. |
Since |
1985fb0 to
2efd389
Compare
Motivation
Address remaining issues of #2785
Modifications
Checklist