Repository navigation
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
EazyReal
force-pushed
the
vmax/weight-loading-loader-side
branch
from
June 25, 2026 19:31
36a4e9b to
d4b09eb
Compare
EazyReal
force-pushed
the
vmax/weight-loading-loader-side
branch
from
June 30, 2026 08:35
d4b09eb to
fe3aeed
Compare
Contributor
Author
|
@kpham-sgl @pyc96 @b8zhong Could I get a quick review and |
Contributor
Author
|
@b8zhong could you take a look at this loader-side weight completeness refactor if you have bandwidth? It moves full-checkpoint checks out of |
EazyReal
force-pushed
the
vmax/weight-loading-loader-side
branch
from
July 7, 2026 18:10
fe3aeed to
06e7e7d
Compare
EazyReal
force-pushed
the
vmax/weight-loading-loader-side
branch
from
July 30, 2026 05:43
06e7e7d to
62d7418
Compare
EazyReal
requested review from
Fridge003,
Ying1123,
hnyls2002,
ispobock,
merrymercy and
mmangkad
as code owners
July 30, 2026 05:43
Contributor
Author
EazyReal
added a commit
to EazyReal/sglang
that referenced
this pull request
Aug 12, 2026
Route built-in partial update paths, including checkpoint-engine IPC, through an explicit load context while preserving full-checkpoint diagnostics by default. Keep DeepSeek-V4 fused-shard atomicity assertions active for every load. Includes the Gemma4 scope from sgl-project#28519. This remains an interim fix pending the loader-owned completeness contract in sgl-project#28585 and sgl-project#29323.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
load_weights(weights)is reused as a tensor-copy primitive by startup loading, online/RL refits, and filtered Elastic-EP recovery. Model-local whole-checkpoint checks therefore fire in contexts that intentionally load only a subset.The underlying contract is still needed on current
main: RFC #28585 remains open, and the Weight Loader v2 tracker #31051 still lists the completeness result and verification contract as unfinished. This PR supplies that boundary without coupling it to one tensor-source implementation.Changes
is_optional_weight(name).The verifier intentionally checks parameters, not buffers. Persistent and derived buffer initialization remains model-owned.
Review context
Verification
62d7418510: https://github.com/sgl-project/sglang/actions/runs/30517415886git diff --checkpasses.python3 -m py_compilepasses on every touched Python file.test/registered/unit/model_loader/test_load_and_verify_weights.pyis registered for CPU CI. The full unit test could not run in this checkout because its Python environment does not include the project dependencies; hosted test matrices require the maintainer-controlledrun-cilabel.