[BUG] Fix stale attention metadata after Eagle pre-planner pads the batch - #29262
Open
1096125073 wants to merge 1 commit into
Open
1096125073 wants to merge 1 commit into
1096125073 wants to merge 1 commit into
Conversation
1096125073
requested review from
Fridge003,
Ying1123,
hnyls2002,
ispobock and
merrymercy
as code owners
June 25, 2026 03:55
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Author
|
@merrymercy Hi, could you help to review this fix? Thanks |
Author
|
/tag-and-rerun-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Eagle speculative decoding + DP-attention (
global_num_tokens_cpuis set) are both enabled,flash_mla_with_kvcacheraises"num_splits must have shape(b+1)"with the following sequence:init_forward_metadatawith the unpadded batchmark_forward_metadata_ready(False)prevents re-initprepare_mlp_sync_batchpadsbatch_sizein-place — but the storedforward_metadatastill hasnum_splitsshaped for the old unpadded batchqwith the padded batch butnum_splitswith the unpadded shape → crashFix
In
_forward_raw(model_runner.py), afterprepare_mlp_sync_batchchanges the batch, detect the staleness and clearforward_metadata_readyto letinit_forward_metadatare-run with the final padded batch: