Repository navigation
[PD] Fix MORI-IO ABORT bootstrap message handling - #29133
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/rerun-test test/registered/amd/disaggregation/test_mori_transfer_engine_e2e.py |
|
|
/rerun-test test/registered/amd/disaggregation/test_mori_transfer_engine_e2e.py |
|
Results for ⛔ |
|
CC: @HaiShaw |
|
The AMD ROCm 7.2 failure is pre-existing on FWIW |
|
@amd-bot ci-status |
CI Status for PR #29133Merge verdict: Caution The one test that covers the changed file — Changed files: Executed CI failure attribution: AMD: 5 failures (0 related) · Others: 2 real failures (0 related) + NPU perf-gate cascades. Downstream AMD/Extra stages skipped by fast-fail (not tested). AMD Executed Failures
Other Executed Failures
(The four CI completeness gaps (fast-fail skipped — NOT tested)
What to do before merge
Generated by amd-bot using Claude Code CLI |
Resolved two conflicts introduced by upstream: * mori/conn.py: sgl-project#29133 landed an equivalent Mori ABORT handler (_TAG_ABORT / _handle_abort_message) that holds transfer_lock across the status read-modify-write and returns early on an already-Failed room. Kept upstream's handler and dropped this branch's _handle_abort_notification, which duplicated it without the lock. sgl-project#29133 also covers the Mori _submit_kv_transfer cleared-room guard this branch carried. * nixl/conn.py: kept the cleared-room guard's room_transfer_infos local alongside the packed_source_by_dcp_rank map added by sgl-project#35762; the two changes are adjacent but independent.
Summary
Fix Mori decode-side
ABORTnotifications being treated as malformed bootstrap messages becauseMORI_GUARDframe validation.This dispatches
ABORTbefore guarded bootstrap payload validation, marks tracked rooms as failed, and avoids stale status/failure-record cleanup issues after abort.CI States
Latest PR Test (Base): ✅ Run #32573036042
Latest PR Test (Extra): ❌ Run #32573035969
Latest PR Test (AMD ROCm 7.2): ❌ Run #32573036069