Skip to content

Fix ModelOpt quantized layers startup log - #28191

Closed
mmangkad wants to merge 1 commit into
mainfrom
mmangkad/fix-modelopt-quantized-layers-report
Closed

Fix ModelOpt quantized layers startup log#28191
mmangkad wants to merge 1 commit into
mainfrom
mmangkad/fix-modelopt-quantized-layers-report

Conversation

@mmangkad

@mmangkad mmangkad commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Put back the quantized_layers tuple check that #18182 removed. Without it, ModelOpt mixed-precision checkpoints hit this online-quantization log, try to unpack a dict, and crash at startup. #27284 fixed the same problem once before after the AMD MXFP4 logging was added in #18005.


CI States

Latest PR Test (Base): ❌ Run #27499037722
Latest PR Test (Extra): ❌ Run #27499037617

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the logic for checking and unpacking quantized_layers during model loading in model_runner.py. It replaces multiple hasattr checks with a direct type and length check on the pre-extracted quantized_layers variable. No review comments were provided, and there is no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mmangkad

Copy link
Copy Markdown
Collaborator Author

/rerun-test test/registered/4-gpu-models/test_nvidia_nemotron_3_super_nvfp4.py

@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/4-gpu-models/test_nvidia_nemotron_3_super_nvfp4.py:

🚀 4-gpu-b200 (1 test): ✅ View workflow run

cd test/ && python3 registered/4-gpu-models/test_nvidia_nemotron_3_super_nvfp4.py

@HaiShaw

HaiShaw commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

#18182 is reverted, we will review with your change, and submit again. Thanks.

@mmangkad mmangkad closed this Jun 15, 2026
auto-merge was automatically disabled June 15, 2026 05:32

Pull request was closed

@mmangkad
mmangkad deleted the mmangkad/fix-modelopt-quantized-layers-report branch June 15, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants