Repository navigation
[diffusion] test: tighten perf baselines - #28123
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
mickqian
added a commit
that referenced
this pull request
Jun 28, 2026
#29519 makes server image warmup use the model default resolution (1024x1024 for FLUX.2-klein), so warmup now specializes kernels for the real inference shape. This shifts per-step CPU-wall-clock timing (step0 drops as it no longer pays first-shape autotune, step2/3 rise to true steady state) WITHOUT changing total work: e2e (483 vs 434 baseline), avg_denoise (40.72 vs 39.98) and median are all within tolerance. The old denoise_step_ms baseline was internally inconsistent: its steps summed to ~27.7ms/step (110.87/4) while expected_avg_denoise_ms was 39.98, because #28123 tightened only step2 (54.97 -> 17.64) without touching avg. Update denoise_step_ms to the measured 1024-warmup values so it is self-consistent with avg (sum/4 = 40.72 ~= 39.98). No code/perf regression; e2e/avg/median baselines unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mickqian
added a commit
that referenced
this pull request
Jun 29, 2026
…blip) fsdp-inference's denoise step6 baseline (232.55) was depressed by #28123 ("CI: tighten perf baselines", 270.89 -> 232.55) onto a single noisy CI sample, leaving denoise_step_ms internally inconsistent (sum/n=293 vs expected_avg_denoise_ms=263.19). The ~600ms cost is a single CPU-wall-clock blip (per-step timers don't sync CUDA) that floats across the denoise loop: the baseline pinned it onto step3 (650.0, done in #28781) but at runtime it lands on step6 instead, while step3 comes back normal (~272). Both step3 and step6 are sampled indices ({0,2,3,5,6,8}), so whichever step catches the blip fails. Give step6 the same ceiling as step3 (232.55 -> 650.0) so either step can absorb the blip. avg_denoise / median / e2e baselines unchanged, so a real compute regression still trips the aggregate checks (no masking). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data Source
Guardrail
scenariosnumeric fields decreased: 1304scenariosnumeric fields increased: 0CI States
Latest PR Test (Base): ✅ Run #27491301212
Latest PR Test (Extra): ❌ Run #27491301151