Improve gemma and documentations - #278
Merged
Merged
Conversation
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Garrybest
pushed a commit
to Garrybest/sglang
that referenced
this pull request
Jan 9, 2026
feat: support larger model distributed
liuxianglong17
pushed a commit
to shun8686/sglang
that referenced
this pull request
Apr 8, 2026
modify testcases
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Jul 28, 2026
…ench, Host-Build ohne CUDA, crossrig_ladder_run (7 Phasen, TSV, Lock-Protokoll) + Analyse-Skript; Messdaten in results/clean/ (2026-07-28, stoerungsfrei)
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Jul 28, 2026
…, Band statt Umschlag, depth>=4 loescht Rueckstau) + DESIGN_201 Nachtrag 12 (dynamisches Dual = Slice D mit Regelschleife)
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Jul 28, 2026
…, Container) — inkl. Rundenzahl-Broadcast-Fix (rangdivergente Warmup-Hochrechnung deadlockte)
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Jul 28, 2026
…2,7x/1,3x schneller als echter SHM-Pfad (solo), Last-Vorbehalt benannt
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Jul 28, 2026
…,3x vor dem echten Pfad solo, Last-Achse relativiert; P4-Wiedereroeffnungsgrund dokumentiert
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Jul 29, 2026
…t): htccl_path_dispatcher.py (PathProfile affine ms(bytes) + Kapazitaet + effektive Apertur + measured|placeholder je Eintrag; decide() je Klasse/Groesse/Lane/Prio mit Saettigungs-Ueberlauf, Latch je log2-Band, Flips nur an Runden-/Capture-Grenzen) + htccl_path_rates.py (Parser p2p_readiness NUR Effektivwerte, sgl-project#278-TSV, NCCL-Referenz-Schema v1 mit Pflicht-p99+Last-Arm); harte Regeln je an einer Stelle erzwungen: Placeholder-Neutralitaet (ohne measured-Daten byte-identische sgl-project#240-Wahl, per Identitaets-Test ueber 3x3x4x4 belegt), Graph-Safety, Prio-Schutz, Offload-Latenz-Term-Anschluss; Bus-Begriff mit sgl-project#286-Arbiter geteilt via benanntem Sensor-Adapter; SGLANG_HTCCL_PATH_DISPATCHER Default aus; 46 neue Tests, distributed-Suite ohne neuen Fehlschlag
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Aug 17, 2026
…, and a lift has THREE twins Part 2 completes the sweep begun in 46e3e30. Scope as stated there: 181 candidate lines over python/sglang/srt (tests excluded), 170 fork-owned. HEADLINE: the TREE is healthy on this axis. Zero DANGLING guards -- every ticket citation resolved to a real commit history or a checkable artifact -- and zero guards needing a lift decision. The rot is concentrated in the planner's REJECTION REGISTER, which part 1 covered. THE ONE VERIFIED STALE-TEXT, fixed: server_args.py:2275 said park-tier routing happens at exhaustion sites "once the sgl-project#236 budget lands". sgl-project#236 landed; park_instead_of_demote is live and called at kv_session_offload.py:3404. The conditional clause is dropped. A CLASSIFICATION I REJECTED AFTER CHECKING IT MYSELF, and the reason it matters more than the row does. The sweep flagged barlink_path_rates.py:21 ("the measurement does not exist yet") as stale because sgl-project#278 closed and load_nccl_reference is implemented. That is wrong: the LOADER existing is not the MEASUREMENT existing. The scripts that would produce the data exist (scripts/gpu_battery/s06_nccl_reference.*, scripts/probe/nccl_reference.py), no data file does, and the consumer at :448 explicitly handles that case by keeping the paths PLACEHOLDER. The docstring is CORRECT. Fixing it would have replaced a true statement with a false one -- which is the exact failure mode this axis is most likely to commit, so it is recorded rather than quietly dropped. THE SHARPEST FIND, and it is on this audit's own axis turned against the test suite: test/registered/unit/server_args/test_phase_flip_args.py:88 still asserts that enable_hierarchical_cache=True raises a ValueError matching "sgl-project#630". sgl-project#703 stage 2 REMOVED that blocker. The test is RED on train/0817-control right now -- verified failing at the untouched base commit with both my edits reverted, so it is not this sweep's doing. That upgrades a lesson the sgl-project#703 lift already half-knew. That lift was careful about TWINS: it moved the parse-time and runtime clauses together because "fixing only the runtime clause is not enough ... both must move together or the flag is still unusable". THERE WAS A THIRD TWIN. The test pinning the gate did not move, so a careful lift still left behind a red test asserting the presence of what it had just deliberately removed. So the lift-evidence bar in the audit gains a fifth item: the tests that pin a gate move WITH it. Two twins were not enough; there are three. NOT FIXED HERE: rewriting a test assertion is not behaviour-neutral for the suite, so it falls outside this sweep's one permitted write. Filed as its own item, with the repair named (drop the sgl-project#630 row from that loop and point at test_hicache_bounded_waits_630.py, which the code comments already name as the active protection). COUNTS, with one discrepancy I am NOT resolving by picking a side: I counted 21 provenance-shaped lines inside my 181-line candidate union; the sweep counted 187 across the whole tree without that pre-filter. Different denominators, both defensible, neither reconciled line by line. Both agree on the shape -- the large majority of #NNN mentions are settled narration and only a handful are live conditions that could expire. Stated rather than averaged. STILL-VALID substantive set spot-checked: the HiCache phase-rebind refusal (nothing in the tree ever sets the host pool it waits for), the sgl-project#578 stage-table refusal (reads liftable in isolation; the full trace shows sgl-project#584's canon fills what it can and this raise is the designed fallback for what it cannot), the sgl-project#452 CUDA-graph refutation (reconfirmed three times, never reversed), the KVSO/HiCache opt-in gate, and topk>1 under uneven DCP. Two loose citations named: layers/dcp/owner.py:127 and layers/attention/triton_backend.py:432 both cite "sgl-project#76", which is an unrelated ticket -- scale analogies written as if they were pointers. The guards are valid; the citations misdirect a reader exactly as the drifted anchors do. Suite: server_args 663 passed, 91 subtests, 1 failed -- the pre-existing test_v1_blockers_named above, verified identical at the untouched base. Catalog updated same step. codespell clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.