[CI] Move misplaced mhc kernel test into test/registered/kernels - #27781
Conversation
`tests/kernels/test_mhc_kernels.py` (added in sgl-project#25976) was the only file under a stray top-level `tests/` directory, outside the repo's `test/` tree, so it was never discovered by the CI runner. - Move it to `test/registered/kernels/test_mhc_kernels.py`, alongside the other kernel correctness tests. - Add the required module-level `register_cuda_ci(...)` so `run_suite.py` picks it up (base-b, 1-gpu-small; small footprint, CUDA + TileLang). - Add the standard pytest `__main__` footer per test/README.md. - Remove the now-empty top-level `tests/` directory. Test body is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request registers the MHC kernels test file for CUDA CI by importing and calling register_cuda_ci with specific configurations. Additionally, it adds a standard main block to allow running the test file directly using pytest. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/rerun-test test/registered/kernels/test_mhc_kernels.py |
|
Results for 🚀 |
The mHC kernels route their TF32 prenorm GEMM through DeepGEMM, which is disabled on the 1-gpu-small (RTX 5090 / SM120) pool — `_compute_enable_deep_gemm` returns False for SM120, so `deep_gemm` is never imported and the test hits `NameError: name 'deep_gemm' is not defined`. Register on 1-gpu-large (H100 / SM90), matching the other DeepGEMM-dependent kernel tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
/rerun-test test/registered/kernels/test_mhc_kernels.py |
|
Results for 🚀 |
…-project#27781) Co-authored-by: Claude <noreply@anthropic.com>
…-project#27781) Co-authored-by: Claude <noreply@anthropic.com>
3 participants
Motivation
tests/kernels/test_mhc_kernels.py(added in #25976) is the only file under a stray top-leveltests/directory, which sits outside the repo'stest/tree. Because the CI runner only scanstest/registered/(and the JIT kernel dirs), this test was never discovered or executed.Modifications
test/registered/kernels/test_mhc_kernels.py, alongside the other kernel correctness tests.register_cuda_ci(est_time=30, stage="base-b", runner_config="1-gpu-small")sorun_suite.pydiscovers it (small memory footprint; requires CUDA + TileLang).__main__footer pertest/README.md.tests/directory.The test body itself is unchanged — this is a pure relocation + CI wiring fix.
Checklist
mhc_pre,mhc_post,mhc_fused_post_pre,is_dsa_prefill_cp_round_robin_split) still exist insglang.srt.layers.mhcest_time/stage/runner_config)test/registered/kernels/tests🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #27263719495
Latest PR Test (Extra): ❌ Run #27263718691