Skip to content

[RL] Skip rotary cache tensors in weight checker - #27692

Merged
ch-wan merged 3 commits into
sgl-project:mainfrom
zhuzilin:zilin/weight-checker-skip-cos-cache
Aug 6, 2026
Merged

ch-wan merged 3 commits into
sgl-project:mainfrom
zhuzilin:zilin/weight-checker-skip-cos-cache

Conversation

@zhuzilin

@zhuzilin zhuzilin commented Jun 9, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Rotary cos/sin cache tensors are deterministic implementation details and may differ in shape across implementations.

Modifications

Skip .cos_sin_cache tensors during weight checker comparisons.

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): 🚫 Run #30919624834
Latest PR Test (Extra): ❌ Run #30919621649

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@zhuzilin zhuzilin changed the title Skip rotary cache tensors in weight checker [RL] Skip rotary cache tensors in weight checker Jun 9, 2026
@b8zhong b8zhong added the run-ci CI: run the baseline test suite on this PR label Jul 16, 2026
@b8zhong
b8zhong enabled auto-merge (squash) July 16, 2026 16:37
@b8zhong b8zhong self-assigned this Aug 5, 2026
@ch-wan
ch-wan disabled auto-merge August 6, 2026 01:21
@ch-wan
ch-wan merged commit f01f706 into sgl-project:main Aug 6, 2026
201 of 247 checks passed
saturn-acc pushed a commit to saturn-acc/sglang that referenced this pull request Aug 16, 2026
Atituiset pushed a commit to Atituiset/sglang that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci CI: run the baseline test suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants