Repository navigation
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/tag-run-ci-label |
|
/rerun-failed-ci |
liujianyeey-oss
left a comment
There was a problem hiding this comment.
Pulled the branch to read — three structural blockers, all probably contributing to the CI red. Inline. Skipping a handful of MAJOR observations on the codec layer (str primitive missing, dec_hook / pickle.loads sink, tensor device drop, _struct_types subclass discovery, rid type narrow) — happy to pile them on if you want; didn't want to drown out the merge-blockers.
I will fix all CI test before asking for merge approval. |
| output_token_ids_logprobs_idx: List[List] | ||
| output_token_entropy_val: List[float] | ||
| input_token_logprobs_val: Optional[ | ||
| List[Optional[List[Optional[Union[float, List[Optional[float]]]]]]] |
There was a problem hiding this comment.
can you just try Optional[List[List[Optional[float]]]]? also do the same for the other variables below this line input_token_logprobs_idx, output_token_logprobs_val, ..
Some example values are
# no logprobs requested
input_token_logprobs_val = None
# one request, prompt logprobs available
# first token has no previous-token probability, so it is None
input_token_logprobs_val = [[None, -0.1832, -2.9417, -0.0048]]
# two requests in a batch
input_token_logprobs_val = [
[None, -0.42, -1.87],
[None, -3.12, -0.09, -5.44],
]
# streaming follow-up chunk after input logprobs were already sent
input_token_logprobs_val = [[]]
# multi-item scoring path: no leading None; values correspond to delimiter positions
input_token_logprobs_val = [[-0.77, -2.35, -0.18]]
so Optional[List[List[Optional[float]]]] should work
| external_trace_header: Optional[Dict[str, str]] = None, | ||
| ): | ||
| self.rid: str = str(rid) | ||
| class TraceReqContext(msgspec.Struct, tag=True): |
There was a problem hiding this comment.
does the tracing still work after your changes?
@sufeng-buaa can you take a review?
…l rely on dataclass
|
/rerun-failed-ci |
Motivation
#23206
Modifications
Followup PR 28688
Done
Pending Migrate
SamplingParams[Done]TraceNullContext[Done]TraceReqContext[Done]mm_inputs/image_inputs[Done]Accuracy Tests
SGLANG_LOG_PICKLE_IPC_OBJECTS=1 CUDA_VISIBLE_DEVICES=0,1,2,3 SGLANG_ENABLE_JIT_DEEPGEMM=1 TORCH_CUDA_ARCH_LIST=10.0 NVSHMEM_IB_ENABLE_IBGDA=0 NVSHMEM_ENABLE_NIC_PE_MAPPING=1 NVSHMEM_DISABLE_LOCAL_ONLY_PROXY=1 NVSHMEM_IB_GID_INDEX=0 NVSHMEM_HCA_LIST=mlx5_0:1,mlx5_3:1,mlx5_4:1,mlx5_5:1 NVSHMEM_BOOTSTRAP_UID_SOCK_IFNAME=eth0 NCCL_IB_GID_INDEX=0 NCCL_IB_HCA=mlx5_0:1,mlx5_3:1,mlx5_4:1,mlx5_5:1 NCCL_MNNVL_ENABLE=1 NCCL_CUMEM_ENABLE=1 NCCL_SOCKET_FAMILY=AF_INET6 GLOO_SOCKET_FAMILY=AF_INET6 NCCL_SOCKET_IFNAME=eth0 GLOO_SOCKET_IFNAME=eth0 SGLANG_DISABLE_TP_MEMORY_INBALANCE_CHECK=1 SGLANG_DEEPEP_NUM_MAX_DISPATCH_TOKENS_PER_RANK=1024 sglang serve --model-path /data03/models/Qwen3-235B-A22B-FP8 --trust-remote-code --tp-size 4 --ep-size 4 --dp-size 4 --enable-dp-attention --enable-dp-lm-head --device cuda --host 0.0.0.0 --port 30000 --mem-fraction-static 0.8 --disable-radix-cache --attention-backend fa3 --moe-runner-backend deep_gemm --max-running-requests 512 --context-length 32768 --chunked-prefill 2048 --reasoning-parser qwen3 --disable-piecewise-cuda-graph --model-loader-extra-config '{"enable_multithread_load": true, "num_threads": 64}' --cuda-graph-max-bs 128GSM8k
Speed Tests and Profiling
Server command:
Concurrency = 1024
msgpack:
pickle:
Concurrency = 1
msgpack:
pickle:
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): 🚫 Run #27725799896
Latest PR Test (Extra): ❌ Run #27725799747