[XPU] Add forward_xpu to Gemma4RMSNorm by reusing existing kernel ops#26262
Closed
CaoE wants to merge 3 commits into
Closed
[XPU] Add forward_xpu to Gemma4RMSNorm by reusing existing kernel ops#26262CaoE wants to merge 3 commits into
CaoE wants to merge 3 commits into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Author
|
/tag-run-ci-label |
sunjiweiswift
approved these changes
May 26, 2026
Contributor
Author
|
This is coverd by #23280. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add
forward_xputo Gemma4RMSNorm by reusing ops already available in sgl-kernel for XPU.Modifications
Refactor
forward_cudainto a shared_forward_implhelper with CUDA path remaining unchanged.Add forward_xpu that leverages the XPU kernel's native 3D stride support.
Note: The XPU gemma_rmsnorm/ rmsnorm kernels already handle non-contiguous 3D inputs via stride-aware row offset computation, so we can skip the flatten-to-2D reshape when the tensor dim is 3 with contiguous last dim.
Generated by my agent.
Accuracy Tests
Covered by sgl-project/sgl-kernel-xpu#216.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): 🚫 Run #26428790998
Latest PR Test (Extra): ❌ Run #26428790936