Repository navigation
[CI] release/v0.5.12: fix base-* suite names dragged in by cherry-picks - #26109
Merged
Kangyan-Zhou merged 1 commit intoMay 22, 2026
Conversation
Two test files on release/v0.5.12 register against the new base-* suite vocabulary (introduced by sgl-project#25420 on main as part of the stage-a/b/c -> base-a/b/c rename), but this branch hasn't done the rename, so test/run_suite.py's PER_COMMIT_SUITES doesn't know those names. Every per-commit job aborts at suite validation with: ValueError: Tests registered to invalid suites: test/registered/.../test_unified_radix_cache_kl_hicache.py: backend=CUDA, suite='base-c-test-8-gpu-h200' Repointing both registrations at the existing stage-* names on this branch (stage-c-test-8-gpu-h200 and stage-a-test-cpu), which are valid entries in PER_COMMIT_SUITES, so CI accepts the cherry-picked tests. The proper fix is the full stage-* -> base-* rename, but that has a wide blast radius across compute_partitions.py, run_suite.py, ~200 register_*_ci sites, and the reusable workflows; it's intentionally deferred from this release. This change is the surgical patch to unblock pr-test runs on release/v0.5.12 right now. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cherry-picked test files on
release/v0.5.12register against the newbase-*suite vocabulary (introduced by #25420 onmainas part of thestage-{a,b,c}→base-{a,b,c}rename), but this branch hasn't done the rename, sotest/run_suite.py'sPER_COMMIT_SUITESdoesn't know those names.Every per-commit job (e.g. run 26279864881 / job 77353155071) aborts at suite validation:
Fix
Repoint both registrations at the existing
stage-*names that ARE present in this branch'sPER_COMMIT_SUITES:test/registered/radix_cache/test_unified_radix_cache_kl_hicache.py:27register_cuda_ci(stage="base-c", ...)register_cuda_ci(stage="stage-c", ...)test/manual/core/test_dsv4_stale_loc_crash.py:34register_cpu_ci(suite="base-a-test-cpu")register_cpu_ci(suite="stage-a-test-cpu")Both
stage-c-test-8-gpu-h200andstage-a-test-cpuare valid suites onrelease/v0.5.12.Why not the proper rename
The full
stage-*→base-*rename has a wide blast radius —scripts/ci/utils/compute_partitions.py(_STAGE_A_OVERRIDES),scripts/ci/utils/slash_command_handler.py(CUDA_SUITE_TO_RUNNER,DEEPEP_SUITES),test/run_suite.py(PER_COMMIT_SUITES), ~200register_*_ci(suite=...)call sites, and 4 workflow files. Doing it coherently onrelease/v0.5.12is significant scope and intentionally deferred. This PR is the surgical 2-line patch to make pr-test dispatches onrelease/v0.5.12actually run.Test plan
check registered tests have CI registryhook (which is the same validation that fails in CI — so the fix is verified locally)pr-test.ymlagainstrelease/v0.5.12withrun_all_tests=trueand confirmcheck-changespasses +stage-a-test-1-gpu-smallreaches the actual test phase🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Missing
run-cilabel -- add it to run CI tests.Latest PR Test (Extra): ❌ Blocked --
run-ciis required first.