Skip to content

[CI] release/v0.5.12: fix base-* suite names dragged in by cherry-picks - #26109

Merged
Kangyan-Zhou merged 1 commit into
sgl-project:release/v0.5.12from
Kangyan-Zhou:fix-base-suite-on-release-v0.5.12
May 22, 2026
Merged

Kangyan-Zhou merged 1 commit into
sgl-project:release/v0.5.12from
Kangyan-Zhou:fix-base-suite-on-release-v0.5.12

Conversation

@Kangyan-Zhou

@Kangyan-Zhou Kangyan-Zhou commented May 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Two cherry-picked test files on release/v0.5.12 register against the new base-* suite vocabulary (introduced by #25420 on main as part of the stage-{a,b,c} → base-{a,b,c} rename), but this branch hasn't done the rename, so test/run_suite.py's PER_COMMIT_SUITES doesn't know those names.

Every per-commit job (e.g. run 26279864881 / job 77353155071) aborts at suite validation:

ValueError: Tests registered to invalid suites:
  test/registered/radix_cache/test_unified_radix_cache_kl_hicache.py:
    backend=CUDA, suite='base-c-test-8-gpu-h200'

Fix

Repoint both registrations at the existing stage-* names that ARE present in this branch's PER_COMMIT_SUITES:

File Before After
test/registered/radix_cache/test_unified_radix_cache_kl_hicache.py:27 register_cuda_ci(stage="base-c", ...) register_cuda_ci(stage="stage-c", ...)
test/manual/core/test_dsv4_stale_loc_crash.py:34 register_cpu_ci(suite="base-a-test-cpu") register_cpu_ci(suite="stage-a-test-cpu")

Both stage-c-test-8-gpu-h200 and stage-a-test-cpu are valid suites on release/v0.5.12.

Why not the proper rename

The full stage-* → base-* rename has a wide blast radius — scripts/ci/utils/compute_partitions.py (_STAGE_A_OVERRIDES), scripts/ci/utils/slash_command_handler.py (CUDA_SUITE_TO_RUNNER, DEEPEP_SUITES), test/run_suite.py (PER_COMMIT_SUITES), ~200 register_*_ci(suite=...) call sites, and 4 workflow files. Doing it coherently on release/v0.5.12 is significant scope and intentionally deferred. This PR is the surgical 2-line patch to make pr-test dispatches on release/v0.5.12 actually run.

Test plan

  • Pre-commit clean, including the check registered tests have CI registry hook (which is the same validation that fails in CI — so the fix is verified locally)
  • After merge, re-dispatch pr-test.yml against release/v0.5.12 with run_all_tests=true and confirm check-changes passes + stage-a-test-1-gpu-small reaches the actual test phase

🤖 Generated with Claude Code


CI States

Latest PR Test (Base): ❌ Missing run-ci label -- add it to run CI tests.
Latest PR Test (Extra): ❌ Blocked -- run-ci is required first.

Two test files on release/v0.5.12 register against the new base-*
suite vocabulary (introduced by sgl-project#25420 on main as part of the
stage-a/b/c -> base-a/b/c rename), but this branch hasn't done the
rename, so test/run_suite.py's PER_COMMIT_SUITES doesn't know those
names. Every per-commit job aborts at suite validation with:

  ValueError: Tests registered to invalid suites:
    test/registered/.../test_unified_radix_cache_kl_hicache.py:
      backend=CUDA, suite='base-c-test-8-gpu-h200'

Repointing both registrations at the existing stage-* names on this
branch (stage-c-test-8-gpu-h200 and stage-a-test-cpu), which are valid
entries in PER_COMMIT_SUITES, so CI accepts the cherry-picked tests.

The proper fix is the full stage-* -> base-* rename, but that has a
wide blast radius across compute_partitions.py, run_suite.py, ~200
register_*_ci sites, and the reusable workflows; it's intentionally
deferred from this release. This change is the surgical patch to
unblock pr-test runs on release/v0.5.12 right now.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions Bot added the hicache Hierarchical Caching for SGLang label May 22, 2026
@Kangyan-Zhou
Kangyan-Zhou merged commit 39f29f0 into sgl-project:release/v0.5.12 May 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hicache Hierarchical Caching for SGLang

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant