Repository navigation
[CI] Run pr-test + pr-test-extra on PRs targeting release/v0.5.12 - #26090
Closed
Kangyan-Zhou wants to merge 1 commit into
Closed
Kangyan-Zhou wants to merge 1 commit into
Kangyan-Zhou wants to merge 1 commit into
Conversation
Adds release/v0.5.12 to the pull_request branches: filter on both pr-test.yml and pr-test-extra.yml so that PRs (including auto-opened cherry-pick PRs) targeting the release branch get the same per-commit CI coverage as main-targeted PRs. pr-test-extra continues to require the `run-ci-extra` label on pull_request events — that gate is unchanged. This is the minimal change to enable release-branch PR testing; the broader sync of pr-test workflow logic from main (the stage-* -> base-* rename and follow-up scheduling fixes) is intentionally deferred, since that rename has a much wider blast radius across compute_partitions.py, run_suite.py, and ~200 register_*_ci(suite=...) call sites that would all need to land coherently. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Kangyan-Zhou
requested review from
Fridge003,
bingxche,
ispobock and
merrymercy
as code owners
May 22, 2026 09:23
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Collaborator
Author
|
Closing — superseded by the workflow_dispatch approach. Release-branch verification is handled by manually dispatching pr-test.yml + pr-test-extra.yml against release/v0.5.12 with run_all_tests=true, which doesn't need the pull_request branches: filter extended. Deleting branch on cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
release/v0.5.12to thepull_request.branches:filter on bothpr-test.ymlandpr-test-extra.ymlso PRs targeting the release branch (including the auto-opened cherry-pick PRs) get the same per-commit CI coverage thatmain-targeted PRs get.Two-line diff, one branch added in each file.
pr-test-extra'srun-ci-extralabel gate onpull_requestevents is unchanged.Why not snapshot the workflows from main
A previous attempt (#26081, closed) tried to snapshot the full set of pr-test workflow files from
mainto also pick up the scheduling and labelling fixes. Code review caught that thestage-* → base-*rename in #25420 has a wide blast radius acrossscripts/ci/utils/compute_partitions.py,scripts/ci/utils/slash_command_handler.py,test/run_suite.py, ~200register_*_ci(suite=...)call sites, and three sibling reusable workflows — landing the snapshot without the rest would break every per-commit job on the release branch.This PR is therefore scoped to the only thing actually needed for release-branch CI to fire: the trigger filter.
Test plan
release/v0.5.12and confirm bothPR TestandPR Test Extra(whenrun-ci-extralabel applied) workflows fire🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #26279648646
Latest PR Test (Extra): ❌ Blocked --
run-ciis required first.