pr-test: schedule 3x -> 2x; fix extra gate skipped on schedule#25872
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
3 tasks
Shunkangz
pushed a commit
to Shunkangz/sglang
that referenced
this pull request
May 27, 2026
mqhc2020
pushed a commit
to mqhc2020/sglang
that referenced
this pull request
Jun 2, 2026
alphabetc1
pushed a commit
to alphabetc1/sglang
that referenced
this pull request
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related changes to the scheduled CI cadence.
1. Reduce schedule frequency from 3x/day to 2x/day
Last 30 scheduled runs of `pr-test.yml`:
Cadence (8h) is barely above runtime (~6h, often pushed past by GHA scheduling delay + GPU queue), so each new scheduled run lands while the previous one is still mid-execution. `concurrency.cancel-in-progress: true` then kills the prior run, wasting GPU runner time and forcing retries.
Between two adjacent 8h slots `main` typically accumulates only a handful of commits — three runs/day end up largely re-validating the same code while consuming a full fresh GPU runner suite each time.
PR push activity by hour (last ~1000 PR runs, UTC):
New cron `0 11,23 * * *`:
2. Fix: `pr-test-extra.yml` whole suite skipped on schedule path
Introduced by #25465: `call-gate` is intentionally skipped on `schedule` (no PR context for label check), but downstream test jobs gate on `needs.call-gate.result == 'success'`, treating `skipped` as failure and skipping the entire extra suite.
Example: https://github.com/sgl-project/sglang/actions/runs/26136273640
Fix: relax downstream `if` to `(success || skipped)` in all extra stage jobs and `sgl-kernel-build-wheels`. `!failure() && !cancelled()` still blocks the PR-path gate-failure case.
CI States
Latest PR Test (Base): ❌ Run #26158094311
Latest PR Test (Extra): ❌ Run #26158094235