Skip to content

[bugfix] Fix wrong chunk cache error#25562

Merged
HaiShaw merged 1 commit into
sgl-project:amd/deepseek_v4from
HaiShaw:amd/deepseek_v4_fix_chunk_cache
May 18, 2026
Merged

[bugfix] Fix wrong chunk cache error#25562
HaiShaw merged 1 commit into
sgl-project:amd/deepseek_v4from
HaiShaw:amd/deepseek_v4_fix_chunk_cache

Conversation

@1am9trash
Copy link
Copy Markdown
Collaborator

@1am9trash 1am9trash commented May 18, 2026

Motivation

PR 22/N switched V4 to SWATokenToKVPoolAllocator, but did not switch ChunkCache to SWAChunkCache at the same time, causing a runtime error:
AttributeError: 'ChunkCache' object has no attribute 'sliding_window_size'

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ❌ Missing run-ci label — add it to run CI tests.
Latest PR Test (Extra): ❌ Blockedrun-ci is required first.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@1am9trash 1am9trash changed the title Fix wrong chunk cache error [bugfix] Fix wrong chunk cache error May 18, 2026
@HaiShaw HaiShaw merged commit b19052c into sgl-project:amd/deepseek_v4 May 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants