ci: extract cuda stage actions + runner_config mapping#25138
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
1a5e48f to
ab0b1e5
Compare
…onfig; pr_head_sha/git_ref via workflow env
a3c1d1a to
3ba6cae
Compare
…e-actions # Conflicts: # .github/workflows/pr-test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack on top of #25197 (already merged): pulls every CUDA stage job in pr-test.yml into 3 composite actions and routes install-script selection through a single
runner_configlookup key.Composite actions
.github/actions/setup-cuda-test-stage— checkout, stage-health / maintenance gates, sgl-kernel wheel download, install. Install script is now looked up byrunner_config(no longer a caller input)..github/actions/run-test-cuda-suite—run_suite.pyinvocation with suite name, partition flags, optional--timeout-per-file, continue-on-error flag..github/actions/teardown-cuda-test-stage— coredump upload + venv cleanup.Mapping
scripts/ci/runner_configs.pyis the single source of truth forrunner_config → install_script. The composite action shells out to it at runtime. Sanity check in CI: everyrunner_configreferenced by a workflow job must exist in the map.Caller stub now ~20 lines per stage
Warmup commands (8-gpu-h200, deepep-4-gpu-h100, deepep-8-gpu-h200) stay inline in the caller since each has different model URLs. Can be folded into the mapping later if it earns its keep.
Scope
CUDA stage jobs only (13 jobs).
stage-a-test-cpukeeps its own bespoke setup (uv pip + protoc + rust cache) since the install path is fundamentally different.AMD / NPU per-commit + nightly suites unchanged — they still use the legacy
register_*_ci(suite=...)path and pr-test-amd.yml / pr-test-npu.yml have their own dispatch.Equivalence verification (all 14 CUDA stage jobs)
Python script renders each stage's effective job spec from both forms (main inline + PR-C caller stub +
_pr-test-stage.ymlreusable workflow) and compares after GHA expression simplification (literal==, ternary&& ||,format(),&&identity) and cosmetic normalization. All 14 stages PASS semantic equivalence; 8 KNOWN intentional changes are flagged separately:upload-cuda-coredumpsartifact-suffix: ${{ matrix.partition }}now standardized to all stages (some stages were missing it on main)Run FA4 jit_kernel tests (SM100+)renamed to genericRun extra pytest, gated by newextra_pytest_pathinput (same script body)https://gist.github.com/hnyls2002/4cbb2fe077b9a6db710b5e5eeb025725