[Spec] Internal rename per N2 v2 naming rule#25014
Merged
Merged
Conversation
hnyls2002
requested review from
1am9trash,
Fridge003,
Qiaolin-Yu,
Ying1123,
fzyzcjy,
hubertlu-tw,
ispobock,
kpham-sgl,
merrymercy,
sufeng-buaa and
xiezhq-hermann
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
hnyls2002
requested review from
BBuf,
Edwardf0t1,
HaiShaw,
ch-wan,
hanming-lu,
hebiao064,
hlu1,
iforgetmyname,
kkHuang-amd,
ping1jing2,
yizhang2077 and
yuan-luo
as code owners
hnyls2002
force-pushed
the
lsyin/spec-internal-rename
branch
from
0d3f0c8 to
1de6758
Compare
hnyls2002
force-pushed
the
lsyin/spec-internal-rename
branch
2 times, most recently
from
2f0c66e to
9362b6e
Compare
Pure internal identifier rename. No external API change in this PR (meta_info JSON keys, Prometheus names, trace_slice keys, paper-aligned spec_accept_rate / spec_accept_length all preserved). External-facing renames + backward-compat aliases will follow in a separate PR. Rule 1 (drop -ed): - num_accepted_tokens* -> num_accept_tokens* - accepted_length, accepted_length_with_bonus -> num_accept_tokens - accept_length_ptr -> num_accept_tokens_ptr - cumulative_accepted_lengths -> cumulative_num_accept_tokens Rule 3 + Rule 4 (accept = with bonus, correct = drafts only, num_X for counts): - num_accepted_drafts* -> num_correct_drafts* - accepted_drafts -> correct_drafts (where it's actually a count of correct drafts) - spec_accepted_drafts -> spec_num_correct_drafts (IPC field; per-req count list) - spec_acceptance_histogram -> spec_correct_drafts_histogram (IPC field) - update_spec_acceptance_histogram -> update_spec_correct_drafts_histogram - accepted_draft_tokens -> correct_draft_tokens - accepted_steps -> num_correct_drafts - compute_dflash_*_accept_len_and_bonus -> compute_dflash_*_correct_drafts_and_bonus Semantic correction: - num_accepted_drafts_filter -> num_accept_tokens_filter (value is actually num_correct_drafts + 1, i.e. with-bonus accept count)
hnyls2002
force-pushed
the
lsyin/spec-internal-rename
branch
from
9362b6e to
466c29e
Compare
This was referenced May 12, 2026
LucQueen
pushed a commit
to LucQueen/sglang
that referenced
this pull request
May 12, 2026
SpencerGarnets
added a commit
to ai-blaise/optimization-playground
that referenced
this pull request
May 12, 2026
…ack) Brings in upstream sgl-project/sglang main commits since 096ad02 (merge base, Laguna-XS.2 model support). Total: 28 upstream commits composed. Custom-stack files preserved intact (entirely-ours, byte-identical to origin/main): - Blackwell CuTe kernel suite (warp_decode_cute, g1_attention_cute, gated_norm_cute, layersplit_cute, fused_store_index_cache) - TurboQuant 2.5-bit dense KV cache path - HIGGS 2-bit dense KV cache path (with split-K decode) - NVFP4 IndexCache dispatcher (active gate) - quantization_config_dispatch (HF-config-driven runtime routing) - All custom server-args flags and runtime methods preserved Verification: - 200+ merged Python files compile cleanly - Dispatcher symbol presence verified - HIGGS pool / TurboQuant pool classes present at expected lines - compressed_tensors_w4a4_nvfp4_moe imports clean - All custom server-args flags present (enable_higgs_dense_2bit_kv_cache, enable_turboquant_dense_kv_cache, turboquant_dense_kv_preset, indexer_quantization_declared, higgs_mla_decode_num_splits, etc.) Manual-merged shared files (auto-merge gave broken/mixed output; cleaned up post-merge): - python/sglang/srt/disaggregation/mooncake/conn.py: upstream's PR#24932 refactored maybe_send_extra into a state-types-loop. Replayed our LayerSplit NSA state-index-length-mismatch check inside the SWA/NSA branch of the new loop body. - sgl-kernel/python/sgl_kernel/__init__.py: upstream's PR#23449 (Apple Silicon Metal kernel) wrapped the entire module body in `if darwin/arm64: from sgl_kernel.metal import * else: ...`. The auto-merge duplicated the file body; rewrote cleanly with upstream's structure and re-injected our `g1_gate_forward`, `warp_decode_cute_moe_forward`, and `warp_decode_cute_moe_packed_forward` imports plus `g1_gate_forward` in _DEBUG_EXPORT_NAMES. - python/sglang/srt/managers/scheduler_output_processor_mixin.py: line 628 still referenced `result.num_accepted_drafts` (renamed by PR sgl-project#25038 to `num_correct_drafts`). Renamed in place. - python/sglang/srt/observability/scheduler_metrics_mixin.py: a block around the spec-decode logging path had mixed old/new names from auto-merge (lines 553/557/560). Renamed `spec_num_accepted_tokens` -> `spec_num_accept_tokens` and local `num_accepted_drafts` -> `num_correct_drafts` to match the rest of the file. - test/test_smc_info.py: stub Req mock used the old field names `spec_accepted_drafts` and `update_spec_acceptance_histogram`. Renamed to `spec_num_correct_drafts` and `update_spec_correct_drafts_histogram` per PR sgl-project#24081. Auto-merge cleanly integrated upstream changes to: - server_args.py (new fields: prefill_only_disable_kv_cache, weight_loader_drop_cache_after_load, prefill_delayer_queue_min_ratio, prefill_delayer_max_delay_ms, speculative_draft_window_size, etc.) - mem_cache/memory_pool.py (new NoOpMHATokenToKVPool) - model_executor/model_runner_kv_cache_mixin.py (NoOpMHATokenToKVPool pool factory + _validate_prefill_only_disable_kv_cache_pool_family) - layers/attention/nsa_backend.py (spec rename num_accepted_drafts -> num_correct_drafts; num_accepted_tokens -> num_accept_tokens) - layers/attention/nsa/nsa_indexer.py (new _apply_q_scale_and_softmax_scale compile method; torch.mm replaces deep_gemm wrapper) - 28+ disaggregation/spec/runner files with mostly clean upstream-side-only integration. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> ----- upstream commit subjects (28) ----- fd3eb77 [Cookbook]: add Laguna-XS.2 (Poolside) (sgl-project#24730) 6be1a45 Fix swa component host hit (sgl-project#25085) 693f497 [NPU] use causal_conv1d_update_v2 for performance (sgl-project#24595) 1efe9e2 [Bug Fix] Reject incompatible combination of --disable-cuda-graph-padding and --enable-torch-compile (sgl-project#23903) 8d27ce7 Optimize uvicorn startup command (sgl-project#25041) b35fd5f [fix] skip legacy minicpmv conv template for MiniCPM-V 4.6 (sgl-project#24998) 7582237 [Tiny Fix] Disable BCG when inner layer_model unresolved (sgl-project#25021) ca3bc05 Deepseek-v4-Pro share expert tp1 (sgl-project#24949) a72d3ae [Spec] Multi-layer mamba scatter cleanup; fix positional call bug (sgl-project#25030) 7128533 Revert "Migrate Intel CPU cases to the test/registered." (sgl-project#25044) 1f985c5 [Spec] Rename `accepted_indices` -> `accept_indices`; drop `_token_id` suffix per Rule 5 (sgl-project#25038) ecf5d84 Migrate Intel CPU cases to the test/registered. (sgl-project#22670) d7f4761 [PD] Refactor hybrid state transfer (sgl-project#24932) 91907b7 [UnifiedTree]: Fix Unified HiCache tombstone lock release replay (sgl-project#24972) 4ad63ad [Spec] Rename `accepted_drafts` -> `correct_drafts` for unambiguous naming (sgl-project#24081) 6bfb365 [PD] Rate limit prefill inflight polling warnings (sgl-project#24967) 6bb79c1 [Linear Attn] Add CUSTOM enum and plugin extensibility for kernel backends (sgl-project#24937) cfc41d5 Fix kimi k2.5 mla eagle + dp attention (sgl-project#25033) 0f3932c [Fix] Qwen3-ASR config: set thinker_config before super().__init__ (sgl-project#24187) f526e3f [Spec] Mamba scatter cleanup; fix multi-layer positional bug; dflash naming (sgl-project#25029) 10375a1 [NIXL][XPU] Fix uint64 overflow for mismatched P/D TP sizes (e.g. prefill_tp=1, decode_tp=2) (sgl-project#24648) 0a37d24 [diffusion] hardware: support sage attention backend on MUSA (attn backend, 21/N) (sgl-project#24752) 5495026 [HiCache] feat: default storage prefetch timeout (sgl-project#23309) 186eb42 Feat: Support SWA (Sliding Window Attention) for EAGLE-3 drafter (sgl-project#24664) a75b79e Feat: Support newer EAGLE-3 drafters (sgl-project#24663) f3a8189 [Spec] Internal rename per N2 v2 naming rule (sgl-project#25014) bfc2eda [MUSA] Use MUSA-optimized operators in piecewise CUDA graph (sgl-project#23633) 74d70af [Apple Silicon] Add Metal kernel support in sgl-kernel (sgl-project#23449)
xjpang
pushed a commit
to xjpang/sglang
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure internal identifier rename. No external API change in this PR —
meta_infoJSON keys, Prometheus names, trace_slice keys, and paper-alignedspec_accept_rate/spec_accept_lengthare all preserved. External-facing renames + backward-compat aliases follow in a separate PR.Scope
Rule 1 (drop
-ed):num_accepted_tokens*→num_accept_tokens*accepted_length,accepted_length_with_bonus→num_accept_tokensaccept_length_ptr→num_accept_tokens_ptrcumulative_accepted_lengths→cumulative_num_accept_tokensRule 3 + Rule 4 (
accept= with bonus,correct= drafts only,num_Xfor counts):num_accepted_drafts*→num_correct_drafts*accepted_drafts→correct_draftsspec_accepted_drafts→spec_num_correct_drafts(IPC field: per-req count list,List[int])spec_acceptance_histogram→spec_correct_drafts_histogram(IPC field: list-of-list, draft-data not count)update_spec_acceptance_histogram→update_spec_correct_drafts_histogramaccepted_draft_tokens→correct_draft_tokensaccepted_steps→num_correct_draftscompute_dflash_*_accept_len_and_bonus→compute_dflash_*_correct_drafts_and_bonusSemantic correction:
num_accepted_drafts_filter→num_accept_tokens_filter(value is actuallynum_correct_drafts + 1, i.e. with-bonus accept count)45 files, +389 -401. Splits the internal trunk out from #24081.