Skip to content

[AMD] Pin cache-dit==1.3.0 in rocm.Dockerfile + AMD CI install script #24924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yctseng0211 merged 6 commits into from
May 11, 2026
Merged

[AMD] Pin cache-dit==1.3.0 in rocm.Dockerfile + AMD CI install script #24924

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a63939c
[AMD CI] upgrade cache-dit to 1.3.0 in install script
cursoragent May 11, 2026
fba6ac9
[AMD CI] trim verbose cache-dit install comments
cursoragent May 11, 2026
5a27b0e
[AMD] pin cache-dit==1.3.0 in rocm.Dockerfile
cursoragent May 11, 2026
723fdd3
Revert "[AMD] pin cache-dit==1.3.0 in rocm.Dockerfile"
cursoragent May 11, 2026
4a50a07
[AMD] bump cache-dit 1.1.8 -> 1.3.0 in pyproject_other.toml diffusion…
cursoragent May 11, 2026
2774de0
[AMD] bump cache-dit 1.1.8 -> 1.3.0 in amd-sglang wheel diffusion_hip
cursoragent May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker/rocm.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ RUN pip install IPython \
&& pip install orjson \
&& pip install python-multipart \
&& pip install torchao==0.9.0 \
&& pip install pybind11
&& pip install pybind11 \
&& pip install cache-dit==1.3.0

@cursor cursor Bot May 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This install is overwritten a few lines below. The next RUN block does:

rm -rf python/pyproject.toml && mv python/pyproject_other.toml python/pyproject.toml
...
python -m pip --no-cache-dir install -e "python[srt_hip,diffusion_hip]"

and diffusion_hip in python/pyproject_other.toml still pins cache-dit==1.1.8, so pip will downgrade cache-dit from 1.3.0 back to 1.1.8 during the sglang editable install. The net effect is that the built image still ships cache-dit==1.1.8, which is exactly why the amd_ci_install_dependency.sh upgrade is required at job start.

To make this line actually do something (or to render it unnecessary), bump cache-dit==1.1.8 → 1.3.0 in python/pyproject_other.toml (diffusion_hip extra, and likely also diffusion_musa) and in 3rdparty/amd/wheel/sglang/pyproject.toml. Otherwise, this line can be dropped from the PR.


RUN pip uninstall -y sgl_kernel sglang
RUN git clone ${SGL_REPO} \
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/amd/amd_ci_install_dependency.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ EOF
docker exec ci_sglang pip install --cache-dir=/sgl-data/pip-cache pytest

# Install cache-dit for qwen_image_t2i_cache_dit_enabled test (added in PR 16204)
docker exec ci_sglang pip install --cache-dir=/sgl-data/pip-cache cache-dit || echo "cache-dit installation failed"
docker exec ci_sglang pip install --cache-dir=/sgl-data/pip-cache --upgrade 'cache-dit==1.3.0' || echo "cache-dit installation failed"

@cursor cursor Bot May 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM — pinning to 1.3.0 matches python/pyproject.toml, and --upgrade is needed because the AMD CI base image ships cache-dit==1.1.8 (since python/pyproject_other.toml and 3rdparty/amd/wheel/sglang/pyproject.toml still pin 1.1.8 for diffusion_hip). Once those pyproject pins are bumped, this --upgrade step will become a no-op but won't hurt to keep as a safety net.


# Install accelerate for distributed training and inference support
docker exec ci_sglang pip install --cache-dir=/sgl-data/pip-cache accelerate || echo "accelerate installation failed"
Expand Down
Loading