[sglang-miles] Cherry-pick #24766: Fix NUMA NVML handle resolution under shuffled CUDA_VISIBLE_DEVICES - #24901
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves NUMA node affinity detection by correctly mapping logical CUDA device indices to physical NVML device indices, which is essential when CUDA_VISIBLE_DEVICES reorders or subsets GPUs. It introduces a helper function _get_nvml_device_index that leverages PyTorch's internal mapping and enhances debug logging in configure_subprocess to include logical and physical GPU IDs. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #24766 (merge commit
7edb4c3) ontosglang-miles.torch.cuda._get_nvml_device_indexbefore callingnvmlDeviceGetHandleByIndex, so NUMA binding follows reorderedCUDA_VISIBLE_DEVICESCUDA_VISIBLE_DEVICESConflict resolution: Minor conflict in
configure_subprocesscontrol flow innuma_utils.py(sglang-miles had a slightly different structure); resolved by taking the upstream version.Test plan
Made with Cursor