[Spec V2] Migrate V2 path to EagleDraftExtendInput; verify returns EagleVerifyOutput#24860
Open
hnyls2002 wants to merge 21 commits into
Open
[Spec V2] Migrate V2 path to EagleDraftExtendInput; verify returns EagleVerifyOutput#24860hnyls2002 wants to merge 21 commits into
hnyls2002 wants to merge 21 commits into
Conversation
…tend_after_decode
…ct_last_verified_seed
hnyls2002
requested review from
Qiaolin-Yu,
Ying1123 and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
1 task
… (batch_result, verify_output)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks on #24859. Brings V2 (overlap) path to the same schema:
_draft_extend_for_decodeand_draft_extend_for_prefillinstallEagleDraftExtendInputasbatch.spec_infofor the draft-extend forward (was: reusingEagleDraftInputacross phases).EagleVerifyInput.samplereturns(EagleVerifyOutput, predict)— the sameEagleVerifyOutputas V1, threadingdraft_extend_inputviaverify_outputinstead of dynamic attribute hacks.EagleVerifyOutputfoldscan_run_cuda_graphso verify returns a single object.# === common / V2 / V1 ===section markers.After this PR, V1 and V2 paths share the spec_info type per phase.
Test plan