Cherry pick weight_checker fp8 dequant fix and non-persistent buffer skip from #21494 - #24532
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This was referenced May 6, 2026
(cherry picked from commit 98b5440)
fzyzcjy
force-pushed
the
cherry_pick_weight_checker/0
branch
from
May 6, 2026 13:09
839c3ac to
35df793
Compare
This was referenced May 6, 2026
LLThomas
pushed a commit
to LLThomas/sglang
that referenced
this pull request
May 8, 2026
…skip from sgl-project#21494 (sgl-project#24532) Co-authored-by: Yueming Yuan <yym022502@gmail.com>
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
…skip from sgl-project#21494 (sgl-project#24532) Co-authored-by: Yueming Yuan <yym022502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the
weight_checker.pychange from #21494 (originally landed on thesglang-milesbranch) ontomain.Original author: @yym022502 (Yueming Yuan). I'm only the courier.
Changes
cos_sin_cache/freqs_cisbuffers in_reset_tensors(non-persistent, get recomputed after weight load).weight_scale_invnames toskip_compare_namesso fp8 scale tensors aren't double-compared.inverse_transform_scale_ue8m0conditional onw_s.dtype == torch.int32(UE8M0 packed format / Blackwell DeepGEMM only); other paths now feedw_sdirectly toblock_quant_dequant.PR chain
First of 3 PRs, all touching
weight_checker.pyonly, cherry-picking weight_checker-related changes fromsglang-milestomain:The next two PRs each cherry-pick only the
weight_checker.pyslice of their source PR (the originals also touched many unrelated files). Please merge in order.Test plan