move topk capturers to srt/state_capturer/ - #24450
Merged
Merged
Conversation
hnyls2002
requested review from
1am9trash,
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Qiaolin-Yu,
Ying1123,
ch-wan,
fzyzcjy,
hebiao064,
hlu1,
hubertlu-tw,
iforgetmyname,
ispobock,
kkHuang-amd,
merrymercy,
ping1jing2 and
xiezhq-hermann
as code owners
May 5, 2026 22:26
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
Co-Authored-By: Yueming Yuan <yym022502@gmail.com> Co-Authored-By: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Co-Authored-By: Ziang Li <ziangli@umich.edu>
Co-Authored-By: Yueming Yuan <yym022502@gmail.com> Co-Authored-By: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Co-Authored-By: Ziang Li <ziangli@umich.edu>
hnyls2002
force-pushed
the
lsyin/state-capturer
branch
from
May 5, 2026 22:31
9a69e1a to
2a6f443
Compare
hnyls2002
added a commit
to PrinsYin/sglang
that referenced
this pull request
May 6, 2026
PR sgl-project#24450 moved RoutedExpertsCapturer into srt/state_capturer/. Re-apply the DeepEP attn-tp all-gather override to the new path. Co-Authored-By: Junrong Lin <33685709+ocss884@users.noreply.github.com>
This was referenced May 6, 2026
This was referenced May 8, 2026
This was referenced May 22, 2026
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
Co-authored-by: Yueming Yuan <yym022502@gmail.com> Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Co-authored-by: Ziang Li <ziangli@umich.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the three capturer files out of
layers/into a new top-level dirsrt/state_capturer/— capture is observability infrastructure (side-effect observers tapping into producer outputs), not a layer (compute component). Aligns with sglang's existing observer modules (eplb/,metrics/,debug_utils/) which all sit atsrt/root.Moves
Why
state_capturer/(notcapture/)capture/collides with cuda graph capture (get_is_capture_mode,graph_runner.capture()).state_capturer/keeps the actor-noun form, scopes the data domain ("runtime model state"), and stays distinct from cuda graph terminology.No behavior change
mv+ import path updates across 9 producer/consumer/test files.