fix(router): make HTTP pool idle timeout configurable#24329
Merged
Kangyan-Zhou merged 2 commits intoMay 7, 2026
Merged
Conversation
revanthreddy-hai
requested review from
CatherineSue,
JustinTong0323,
slin1237 and
wisclmy0611
as code owners
github-actions
Bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable idle timeout for the upstream HTTP connection pool, defaulting to 50 seconds. Changes include adding the --pool-idle-timeout-secs CLI argument (and corresponding environment variable), updating the RouterConfig and AppContext to handle this new parameter, and providing documentation in the README and feature guides. The review feedback suggests defining a shared constant for the default timeout value to avoid magic numbers and ensure consistency between the configuration defaults and the CLI argument definition.
Signed-off-by: Revanth Reddy Airre <revanthreddy@hippocraticai.com>
revanthreddy-hai
force-pushed
the
fix/smg-pool-idle-timeout-config
branch
from
dfe247c to
f326303
Compare
Collaborator
|
/tag-and-rerun-ci |
Kangyan-Zhou
approved these changes
May 6, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SGLang Model Gateway's upstream HTTP connection pool idle timeout configurable while preserving the existing 50s default.
This gives operators a way to align SMG's upstream connection pool behavior with the keep-alive / idle-timeout settings used by their deployment, such as sglang workers, ingress-nginx, Envoy/Istio/K-gateway, ALB, or other gateways.
Changes:
Tests