[diffusion] cli: support component attention backend overrides#24320
Merged
mickqian merged 7 commits intoMay 5, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the --component-attention-backends CLI argument, allowing users to specify per-component attention backend overrides (e.g., text_encoder=torch_sdpa). The implementation includes updates to the attention selector to support ContextVar-based overrides, integration into component loaders and pipeline construction, and logic in ServerArgs to parse both comma-separated strings and dotted CLI arguments. Documentation and unit tests have been updated accordingly. I have no feedback to provide.
Collaborator
Author
|
/tag-and-rerun-ci |
LucQueen
pushed a commit
to LucQueen/sglang
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--component-attention-backendsfor per-component native attention backend overrides.Test
git diff --checkImportError: cannot import name '_cuda_beginAllocateCurrentThreadToPool' from 'torch.cuda.memory'.