[CI] Keep custom sgl-kernel wheel in CUDA CI#24291
Merged
Kangyan-Zhou merged 1 commit intoMay 3, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ci_install_dependency.sh script to conditionally install the sglang-kernel. It introduces the CUSTOM_BUILD_SGL_KERNEL environment variable, which, when set to true, prevents the script from overwriting a freshly built kernel wheel with one from the remote index. I have no feedback to provide.
Collaborator
|
/tag-and-rerun-ci |
Collaborator
|
@mmangkad thanks for the fix! |
LucQueen
pushed a commit
to LucQueen/sglang
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression from #21247 where CUDA CI always force-reinstalled
sglang-kernelfrom the public wheel index, which could overwrite a freshly built PRsgl-kernelwheel whenCUSTOM_BUILD_SGL_KERNEL=true.Keep the custom-built wheel in that path so CI actually tests kernel changes from the PR.
See https://github.com/sgl-project/sglang/actions/runs/25264102281/job/74077130931?pr=24281#step:6:380.
cc @Kangyan-Zhou