Skip to content

[AMD] fix moriep unittest failure#24205

Merged
HaiShaw merged 1 commit into
sgl-project:mainfrom
HaiShaw:fix_ut_specv2
May 1, 2026
Merged

[AMD] fix moriep unittest failure#24205
HaiShaw merged 1 commit into
sgl-project:mainfrom
HaiShaw:fix_ut_specv2

Conversation

@billishyahao
Copy link
Copy Markdown
Contributor

@billishyahao billishyahao commented May 1, 2026

Motivation

Recently Specv2 is by default enabled in sglang main branch #21062 which introduces regression error https://github.com/sgl-project/sglang/actions/runs/25151525365/job/73798865426#step:7:16755 for moriep unittest. This PR resolved this through disabling specv2 to restore previous behaviour. For the follow-up, we will create follow-up PR to address the specv2 + moriep tbo compatibility.

cc @HaiShaw @Duyi-Wang @bingxche

Modifications

Accuracy Tests

image

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@HaiShaw HaiShaw merged commit a578bf8 into sgl-project:main May 1, 2026
60 of 66 checks passed
vguduruTT pushed a commit to vguduruTT/sglang that referenced this pull request May 2, 2026
LucQueen pushed a commit to LucQueen/sglang that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants