support asymmetric pd-mtp via mock spec hidden#23958
Merged
hnyls2002 merged 3 commits intodsv4-rebasefrom Apr 28, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This was referenced Apr 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always size the PD MetadataBuffers hidden_states buffer to model_config.spec_hidden_size on both prefill and decode (instead of conditional on local --speculative-algorithm). This unblocks asymmetric P/D configs where prefill runs no spec module but decode runs EAGLE/MTP: prefill ships a zero-initialized buffer that decode consumes as mock conditioning for the first draft step. Verified spec decoding keeps the output token correct -- only the first decode iteration's accept length is affected (~ < 1% throughput hit on long generations).
Cost: when neither side runs spec, the buffer is allocated but unused (~few MB). The alternative is a wire-protocol size mismatch on asymmetric configs.
Test: test_dsv4_pd_disagg_nixl.py uses asymmetric config (prefill TP-only, decode TP+DP+EAGLE), no new server arg required. Follow-up to #23918.