fix: restore FP4 deepgemm path for Blackwell broken by #23686#23948
Merged
Fridge003 merged 2 commits intoApr 28, 2026
Conversation
The Hopper w4a16 PR (sgl-project#23686) restructured the FP4 expert weight processing branches in a way that blocks the default deepgemm/auto backend path with a NotImplementedError. This restores the original logic and treats marlin as the special-case addition.
yhyang201
requested review from
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg and
ch-wan
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the weight processing logic for FP4 experts in fp8.py by consolidating the conversion of weight data to torch.int8 and simplifying the conditional logic for MoE runner backends. I have no feedback to provide as there were no review comments.
ispobock
reviewed
Apr 28, 2026
| layer.w13_weight.data = layer.w13_weight.data.view(torch.int8) | ||
| layer.w2_weight.data = layer.w2_weight.data.view(torch.int8) | ||
|
|
||
| if get_moe_runner_backend().is_marlin(): |
Collaborator
There was a problem hiding this comment.
we don't need the pass branch here. just comment here if you want to notice marlin.
Collaborator
There was a problem hiding this comment.
I think we also need to add comments to clarify the three moe backends we supported and which branch they should go.
yhyang201
force-pushed
the
fix/fp4-blackwell-deepgemm
branch
from
018b03b to
864a61a
Compare
yhyang201
force-pushed
the
fix/fp4-blackwell-deepgemm
branch
from
864a61a to
d3e63aa
Compare
Fridge003
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan