Skip to content

[AMD] Update test_gpt_oss_1gpu.py #23829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yctseng0211 wants to merge 2 commits into from
Closed

[AMD] Update test_gpt_oss_1gpu.py #23829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64812eb
Update test_gpt_oss_1gpu.py
yctseng0211 Apr 27, 2026
ffa5c7b
Update test_gpt_oss_1gpu.py
yctseng0211 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions test/registered/core/test_gpt_oss_1gpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import os
import unittest

from sglang.srt.utils import is_hip
from sglang.test.ci.ci_register import register_amd_ci, register_cuda_ci
from sglang.test.gpt_oss_common import BaseTestGptOss

Expand All @@ -9,15 +11,24 @@

class TestGptOss1Gpu(BaseTestGptOss):
def test_mxfp4_20b(self):
self.run_test(
model_variant="20b",
quantization="mxfp4",
expected_score_of_reasoning_effort={
"low": 0.34,
"medium": 0.34,
"high": 0.27, # TODO investigate
},
)
prev = os.environ.get("SGLANG_USE_AITER")
if is_hip():
os.environ["SGLANG_USE_AITER"] = "1"
try:
self.run_test(
model_variant="20b",
quantization="mxfp4",
expected_score_of_reasoning_effort={
"low": 0.34,
"medium": 0.34,
"high": 0.27, # TODO investigate
},
)
finally:
if prev is None:
os.environ.pop("SGLANG_USE_AITER", None)
else:
os.environ["SGLANG_USE_AITER"] = prev
Comment on lines +14 to +31
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The manual management of environment variables using try...finally is verbose and can be simplified using unittest.mock.patch.dict. This approach is more idiomatic for Python tests and ensures the environment is correctly restored even if exceptions occur during setup or execution. It also prevents potential environment leakage to subsequent tests.

        from unittest.mock import patch
        env_updates = {"SGLANG_USE_AITER": "1"} if is_hip() else {}
        with patch.dict(os.environ, env_updates):
            self.run_test(
                model_variant="20b",
                quantization="mxfp4",
                expected_score_of_reasoning_effort={
                    "low": 0.34,
                    "medium": 0.34,
                    "high": 0.27,  # TODO investigate
                },
            )


def test_bf16_20b(self):
self.run_test(
Expand Down
Loading