Enable flashinfer::trtllm_allreduce_fusion with PDL#23765
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the flashinfer_allreduce_residual_rmsnorm function in flashinfer_comm_fusion.py by adding the trigger_completion_at_end argument to an internal call. The review feedback correctly points out that this argument is hardcoded to False, which ignores the value provided via the function's parameter, and suggests passing the parameter variable instead.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
0c630c2 to
01ec4ab
Compare
BBuf
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For BS = 1:

With PDL:

Thus, the latency of AR can be (nearly) fully hidden here.
Modifications
With regards to read after write hazards in the dependent kernel, it will only happen when:
PDL is issued without
griddepcontrol.wait, which never is in the case in:fp4_quantizein all backends in Flashinfer, andfused_a_gemm. If there is no PDL signal (like in per token quant 8bit v2), then it will fully serialize like before (for ex, see the cvt_fp16_to_fp4 in thesgl-kernelone, which does not issue either PDL or GDC await. However, when we switch to #23745 (comment) for quantize, it will work properly.Accuracy Tests
Speed Tests and Profiling
109 -> 111.20 tps