[diffusion] quant: Add flag for runtime quantization#23373
Closed
avjves wants to merge 11 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces runtime FP8 quantization support by adding a --quantization CLI argument and updating the quantization configuration resolution process. Feedback indicates that the refactoring of _resolve_quant_config contains regressions, including the use of stale configuration names and incorrect early returns that skip essential NVFP4 inference and metadata probing.
2 tasks
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
mickqian
approved these changes
Apr 21, 2026
Collaborator
|
/tag-and-rerun-ci |
mickqian
reviewed
Apr 23, 2026
Collaborator
mickqian
left a comment
There was a problem hiding this comment.
could you update the doc as a follow up
Contributor
Author
|
@mickqian I updated the docs now :) |
Collaborator
|
/rerun-failed-ci |
Contributor
Author
|
Closing, as #20922 was merged that already adds this support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there's no way to quantize the model weights (linear layers) during runtime. Instead, only pre-quantized transformers are supported. This PR adds a new flag
--quantizationthat can be used to do quantization on-the-fly.Currently it only supports FP8 quantization, as out of the currently supported techniques, FP8 is the only one suited for runtime quantization.
Modifications
--quantizationfor quantizing the model during runtime.Accuracy Tests
No quantization (bf16):
Offline quantization before running (fp8):
Runtime quantization (fp8):
This PR doesn't add any new quantization techniques, but the perf report below highlights that the quantization is used.
1. High-level Summary
2. Stage Breakdown
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci