Skip to content

[ROCm] Uniform docker to support AMD AINIC, BRCM Thor2 IBGDA NIC for MoRI-EP #23263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaiShaw merged 4 commits into from
Apr 21, 2026
Merged

[ROCm] Uniform docker to support AMD AINIC, BRCM Thor2 IBGDA NIC for MoRI-EP #23263

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f75490
Update rocm.Dockerfile to install bxnt driver for supporting IBGDA
Apr 20, 2026
3f80444
Resolve ai assistent comment
Apr 21, 2026
5e8d421
remove --build-arg NIC_BACKEND=ainic and add some comments
Apr 21, 2026
e0b75af
more comments
HaiShaw Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions docker/rocm.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ ARG MORI_REPO="https://github.com/ROCm/mori.git"
ARG MORI_COMMIT="v1.1.0"

# AMD AINIC apt repo settings
ARG AINIC_VERSION=1.117.5
ARG AINIC_VERSION=1.117.5-a-38
Comment thread
kkHuang-amd marked this conversation as resolved.
ARG UBUNTU_CODENAME=jammy
USER root

Expand Down Expand Up @@ -267,6 +267,9 @@ ENV CARGO_BUILD_JOBS=4

# Build and install sgl-model-gateway
RUN python3 -m pip install --no-cache-dir maturin \
&& sed -i -E 's|^(smg-[a-zA-Z-]+)\s*=\s*"~1\.0\.0"|\1 = "=1.0.0"|' \
/sgl-workspace/sglang/sgl-model-gateway/Cargo.toml \
&& grep -E '^smg-' /sgl-workspace/sglang/sgl-model-gateway/Cargo.toml \
&& cd /sgl-workspace/sglang/sgl-model-gateway/bindings/python \
Comment thread
kkHuang-amd marked this conversation as resolved.
&& ulimit -n 65536 && maturin build --release --features vendored-openssl --out dist \
&& python3 -m pip install --force-reinstall dist/*.whl \
Expand Down Expand Up @@ -383,8 +386,25 @@ RUN /bin/bash -lc 'set -euo pipefail; \
# NIC backend deps — mori auto-detects NIC at runtime (MORI_DEVICE_NIC env var override).
# Only vendor packages are installed here for dlopen (e.g. libionic.so); no compile-time flags needed.
case "${NIC_BACKEND}" in \
# default: mlx5
# default: install ainic and bxnt driver
none) \
apt-get update && apt-get install -y --no-install-recommends ca-certificates curl gnupg apt-transport-https && \
rm -rf /var/lib/apt/lists/* && mkdir -p /etc/apt/keyrings; \
curl -fsSL https://repo.radeon.com/rocm/rocm.gpg.key | gpg --dearmor > /etc/apt/keyrings/amdainic.gpg; \
echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/amdainic.gpg] https://repo.radeon.com/amdainic/pensando/ubuntu/${AINIC_VERSION} ${UBUNTU_CODENAME} main" \
> /etc/apt/sources.list.d/amdainic.list; \
apt-get update && apt-get install -y --no-install-recommends \
libionic-dev \
ionic-common \
; \
rm -rf /var/lib/apt/lists/*; \
&& install -m 0755 -d /etc/apt/keyrings \
&& curl -fsSL https://packages.broadcom.com/artifactory/api/security/keypair/PackagesKey/public -o /etc/apt/keyrings/broadcom-nic.asc \
&& chmod a+r /etc/apt/keyrings/broadcom-nic.asc \
&& echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/broadcom-nic.asc] https://packages.broadcom.com/artifactory/ethernet-nic-debian-public jammy main" > /etc/apt/sources.list.d/broadcom-nic.list \
&& apt-get update \
&& apt-get install -y ibverbs-utils bnxt-rocelib=235.2.86.0 \
&& cp /usr/local/lib/x86_64-linux-gnu/libbnxt_re* /usr/local/lib/. \
;; \
Comment thread
kkHuang-amd marked this conversation as resolved.
# AMD NIC
ainic) \
Expand All @@ -399,10 +419,18 @@ RUN /bin/bash -lc 'set -euo pipefail; \
; \
rm -rf /var/lib/apt/lists/*; \
;; \
# TODO: Add Broadcom bnxt packages/repos here later.
# bnxt) \
# echo "[MORI] NIC_BACKEND=bnxt: USE_BNXT=ON. Add Broadcom bnxt packages/repos here later."; \
# ;; \
bnxt) \
echo "[MORI] Enabling Broadcom BNXT backend"; \
apt-get update \
&& apt-get install -y --no-install-recommends ca-certificates curl \
&& install -m 0755 -d /etc/apt/keyrings \
&& curl -fsSL https://packages.broadcom.com/artifactory/api/security/keypair/PackagesKey/public -o /etc/apt/keyrings/broadcom-nic.asc \
&& chmod a+r /etc/apt/keyrings/broadcom-nic.asc \
&& echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/broadcom-nic.asc] https://packages.broadcom.com/artifactory/ethernet-nic-debian-public jammy main" > /etc/apt/sources.list.d/broadcom-nic.list \
&& apt-get update \
&& apt-get install -y ibverbs-utils bnxt-rocelib=235.2.86.0 \
&& cp /usr/local/lib/x86_64-linux-gnu/libbnxt_re* /usr/local/lib/. \
;; \
*) \
echo "ERROR: unknown NIC_BACKEND=${NIC_BACKEND}. Use one of: none, ainic"; \
exit 2; \
Expand Down
Loading