Skip to content

[CI] Exclude diffusion-specific paths from main_package filter#23053

Merged
BBuf merged 3 commits into
sgl-project:mainfrom
LLThomas:workflow-issue
Apr 20, 2026
Merged

[CI] Exclude diffusion-specific paths from main_package filter#23053
BBuf merged 3 commits into
sgl-project:mainfrom
LLThomas:workflow-issue

Conversation

@LLThomas
Copy link
Copy Markdown
Contributor

@LLThomas LLThomas commented Apr 17, 2026

Motivation

Closes #21990

When a Diffusion PR modifies files under python/sglang/jit_kernel/diffusion/, python/sglang/jit_kernel/tests/diffusion/, python/sglang/jit_kernel/benchmark/diffusion/, or python/sglang/cli/, it incorrectly triggers LLM CI jobs (stage-a, stage-b, etc.). This is because the main_package path filter in pr-test.yml only excluded multimodal_gen, so changes to these diffusion-specific paths matched the python/sglang/!(multimodal_gen)/** glob and set main_package=true.

Modifications

Modified .github/workflows/pr-test.yml in two places:

  1. paths-filter glob (line 130)
Before:
python/sglang/!(multimodal_gen)/**/!(*.md)

After:
python/sglang/!(multimodal_gen|jit_kernel/diffusion|jit_kernel/tests/diffusion|jit_kernel/benchmark/diffusion|cli)/**/!(*.md)

Extended the negation pattern to also exclude jit_kernel/diffusion, jit_kernel/tests/diffusion, jit_kernel/benchmark/diffusion, and cli from the main_package filter.

  1. API-based fallback grep filter (line 192)
Before:
grep -v "^python/sglang/multimodal_gen/"

After:
grep -v -E "^(python/sglang/multimodal_gen/|python/sglang/jit_kernel/diffusion/|python/sglang/jit_kernel/tests/diffusion/|python/sglang/jit_kernel/benchmark/diffusion/|python/sglang/cli/)"

The API-based change detection (used for workflow_dispatch with target_stage) had the same gap — it only excluded multimodal_gen/. Extended the grep -v filter to exclude all diffusion-specific paths.

Note: these paths are already covered by the multimodal_gen filter (lines 139-142), so Diffusion PRs will still correctly trigger the multimodal_gen CI jobs.

Accuracy Tests

N/A

Speed Tests and Profiling

N/A

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@LLThomas
Copy link
Copy Markdown
Contributor Author

Hi @ping1jing2 , plz take a look at this when you have free time.

Comment thread .github/workflows/pr-test.yml Outdated
Copy link
Copy Markdown
Contributor

@Makcum888e Makcum888e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ping1jing2
Copy link
Copy Markdown
Collaborator

/tag-and-rerun-ci

@BBuf BBuf merged commit 3063d64 into sgl-project:main Apr 20, 2026
59 of 63 checks passed
Copy link
Copy Markdown
Collaborator

@mickqian mickqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zhangying098 pushed a commit to zhangying098/sglang that referenced this pull request Apr 23, 2026
kyx1999 pushed a commit to KMSorSMS/sglang that referenced this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][NPU] Diffusion PR#21633 should not trigger LLM CIs

5 participants