[CI] Exclude diffusion-specific paths from main_package filter#23053
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
Author
|
Hi @ping1jing2 , plz take a look at this when you have free time. |
Makcum888e
reviewed
Apr 17, 2026
Collaborator
|
/tag-and-rerun-ci |
BBuf
approved these changes
Apr 20, 2026
mickqian
reviewed
Apr 22, 2026
zhangying098
pushed a commit
to zhangying098/sglang
that referenced
this pull request
Apr 23, 2026
…roject#23053) Co-authored-by: ronnie_zheng <zl19940307@163.com>
kyx1999
pushed a commit
to KMSorSMS/sglang
that referenced
this pull request
Apr 27, 2026
…roject#23053) Co-authored-by: ronnie_zheng <zl19940307@163.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #21990
When a Diffusion PR modifies files under python/sglang/jit_kernel/diffusion/, python/sglang/jit_kernel/tests/diffusion/, python/sglang/jit_kernel/benchmark/diffusion/, or python/sglang/cli/, it incorrectly triggers LLM CI jobs (stage-a, stage-b, etc.). This is because the main_package path filter in pr-test.yml only excluded multimodal_gen, so changes to these diffusion-specific paths matched the python/sglang/!(multimodal_gen)/** glob and set main_package=true.
Modifications
Modified .github/workflows/pr-test.yml in two places:
Extended the negation pattern to also exclude jit_kernel/diffusion, jit_kernel/tests/diffusion, jit_kernel/benchmark/diffusion, and cli from the main_package filter.
The API-based change detection (used for workflow_dispatch with target_stage) had the same gap — it only excluded multimodal_gen/. Extended the grep -v filter to exclude all diffusion-specific paths.
Note: these paths are already covered by the multimodal_gen filter (lines 139-142), so Diffusion PRs will still correctly trigger the multimodal_gen CI jobs.
Accuracy Tests
N/A
Speed Tests and Profiling
N/A
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci